[storybook] Remove need for yarn-link#116
Merged
Merged
Conversation
oliviertassinari
force-pushed
the
no-more-yarn-link
branch
from
July 27, 2020 01:15
29beaa0 to
9ad13fe
Compare
dtassone
reviewed
Jul 27, 2020
oliviertassinari
force-pushed
the
no-more-yarn-link
branch
5 times, most recently
from
August 2, 2020 16:57
45d4ad1 to
dc4c5f1
Compare
oliviertassinari
force-pushed
the
no-more-yarn-link
branch
from
August 2, 2020 16:58
dc4c5f1 to
d3fb499
Compare
oliviertassinari
marked this pull request as ready for review
August 2, 2020 17:15
oliviertassinari
force-pushed
the
no-more-yarn-link
branch
3 times, most recently
from
August 2, 2020 17:51
d784f73 to
eeeb793
Compare
oliviertassinari
force-pushed
the
no-more-yarn-link
branch
from
August 2, 2020 17:57
eeeb793 to
b9edd97
Compare
This was referenced Aug 2, 2020
Closed
Member
Author
|
Note that I didn't use Babel to solve the problem, webpack aliases did most of the job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the need to yarn link or build, the storybook just work™. (I have almost never managed to make it work locally before that): 9ad13fe.
Fix #143