You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds test coverage for createPackageImports handling subpath imports entries whose condition leaves are bare specifiers pointing at external package files (not internal source paths).
Motivated by mui/material-ui#48645 (comment), which proposes mapping #mui/TransitionGroupContext to per-condition external files, e.g.:
The build already supports this — it emits the mapping verbatim — but it wasn't covered. Existing tests only exercised a flat bare specifier and a conditions-outer object with internal source paths. Two cases are added:
A conditions-outer object of bare specifiers, asserting passthrough and condition-key order preservation (Node's condition matching is order-sensitive).
A nested import/require/default object of bare specifiers, which exercises the sortExportConditions path and confirms the specifiers aren't rewritten or reordered.
Janpot
added
the
scope: code-infra
Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).
label
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scope: code-infraInvolves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Janpot
added
the
scope: code-infra
Adds test coverage for
createPackageImportshandling subpathimportsentries whose condition leaves are bare specifiers pointing at external package files (not internal source paths).Motivated by mui/material-ui#48645 (comment), which proposes mapping
#mui/TransitionGroupContextto per-condition external files, e.g.:The build already supports this — it emits the mapping verbatim — but it wasn't covered. Existing tests only exercised a flat bare specifier and a conditions-outer object with internal source paths. Two cases are added:
import/require/defaultobject of bare specifiers, which exercises thesortExportConditionspath and confirms the specifiers aren't rewritten or reordered.