[core] Prepare migration with main repository, eslint v1#1937
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mui-org/material-ui-pickers/27ynkr35u |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
3590721 to
85e000d
Compare
|
What the motivation of bringing this 2 parts in different PRs? I think they should never be merged independently. Maybe change the base branch to #1930? |
|
|
||
| return ( | ||
| <> | ||
| <React.Fragment> |
There was a problem hiding this comment.
What the motivation?
There was a problem hiding this comment.
Why are we using <React.Framgent> in the codebase? I think that it's between these lines:
- Only this approach allows setting a
key - Only this approach allows new developers to easily search on Google what the element for.
- We enforce one way for consistency.
If you think that we should change the tradeoff, please open an RFC on the main repository to make the point. The objective here is to share the same eslint configuration on the whole codebase.
I was planning on making more than 2 pull requests, more like a couple. The incentive is incremental changes: avoid conflicts on large pull requests, makes review easier. #1930 will finalize the effort, putting constraints in place so it holds in the long term. Step by step. |
oliviertassinari
changed the title
2 participants
This is a smaller chunk of #1930. I have figured that it would be much easier to have this effort go into smaller efforts.