[core] Move svg-icons to the internal folder#9601
Merged
Merged
Conversation
oliviertassinari
force-pushed
the
svg-icons-move-internal
branch
from
December 22, 2017 20:41
e1d7acf to
ecdb7d9
Compare
oliviertassinari
force-pushed
the
svg-icons-move-internal
branch
from
December 22, 2017 20:57
ecdb7d9 to
57d1881
Compare
mbrookes
approved these changes
Dec 22, 2017
zannager
added
component: SvgIcon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was suggested by @kgregory in #9532 (comment) 👍 .
(Another quick win I was able to do in the subway today)
Those components have never been exported, they have always been private. It's about making this fact obvious.