[flow] Upgrade to flow 0.53.1 by rosskevin · Pull Request #7869 · mui/material-ui

rosskevin · 2017-08-23T00:59:22Z

This is a massive changeset to accomodate the major change in flow's built-in libdef for react. The changes and reference to docs are outlined in the release notes: https://github.com/facebook/flow/releases/tag/v0.53.0

Given this huge changeset, it is virtually un-reviewable.

Once the tests pass on CircleCI, I'll be squash merging, and I pledge to handle what would normally be reviewable separately and timely.

PR has tests / docs demo, and is linted.
Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

- ran flow-upgrade - switch React.Element<any> references to React.Node - switch all react imports to `* as React` and use the React.* for access to uniformly access both function and types - linted

flow-typed/flow-typed#1165

This isn’t a fix, it just gets past the error. I assume generated prop types are still invalid.

* [docs] Fix missing props in css-in-js examples `this.classes.root` wouldn't work - `this.props.classes.root' would. * Update css-in-js.md

rosskevin · 2017-08-23T01:04:34Z

Some notes to those that find this, to use flow + react in what was formerly known as weak mode, you can simply do React.Component<any, any>. The flow-upgrade will put in React.Component<$FlowFixMeProps, $FlowFixMeState> but if you have zero plans to use flow, using <any, any> is fine.

rosskevin · 2017-08-23T01:13:49Z

Docs are failing so more left...

rosskevin · 2017-08-23T01:35:10Z

Docs are working again. Another FYI, with this PR I've converted several additional components to Flow, increasing our coverage.

rosskevin · 2017-08-23T02:11:51Z

react-docgen continues to fail, namely on ButtonBase

@oliviertassinari - do you see anything on ButtonBase that would cause react-docgen to just fail entirely? I couldn't find anything

oliviertassinari · 2017-08-23T11:26:50Z

 // @flow

-import React from 'react';
+import * as React from 'react';


Why do we need to perform such change? I have never seen such pattern for importing React. That's hiding something.

The only migration I could find so far: https://github.com/facebook/react/pull/10510/files

It allows import of both types and functions. Without it we need to import everything separately. Since the migration tool automatically does this and all examples use it, it seemed to be what users are most likely to be familiar with. We can incrementally switch to individual imports.

All the documentation references it this way: https://flow.org/en/docs/react/components/

Specifically addressed in the note here: https://flow.org/en/docs/react/children/

Sounds good then for the source code 👍. I haven't looked at the demos, but I don't think that they should be flowtyped covered as used in an unknown environnement. We have been using flow weak so far.

Demos I have kept as weak as possible. The only change was I had to change extends React.Component to extends React.Component<any, any>

@rosskevin Won't that break with users using Typescript or not using the babel flow plugin?

Maybe we could disable flow for the demo folders instead.

I'm not sure if it will break without the flow type stripping plugin or not. If we decide to, I'll PR separate.

I'm not sure if it will break without the flow type stripping plugin or not

Yes, it does.

rosskevin · 2017-08-23T15:00:47Z

I have created #7880 to get the docgen working properly again.

oliviertassinari · 2017-08-23T15:29:14Z

Do you plan on fixing #7881, #7880 as well as the demos before merging this PR? Otherwise I fear they will stay unsolved.

rosskevin · 2017-08-23T15:32:44Z

No on #7880, I'm hoping somebody will pick up the docgen issue, it affects every single flow user of docgen. Worst case if someone doesn't pick up in a week I can look at it.

No on #7881, I'm going to address it next (today). It is a pre-existing problem and not caused by this PR (a small amount of growth is). I think I can solve that one today due to my familiarity with PRing on that plugin.

rosskevin · 2017-08-23T15:35:49Z

Will address #7882 demos today as well.

oliviertassinari · 2017-08-23T15:39:56Z

@rosskevin Awesome, one step at the time 👍

rsolomon · 2017-08-23T16:10:53Z

Nice work!

rosskevin and others added 30 commits August 22, 2017 09:15

[flow] upgrade flow-bin

2caa486

[flow] initial flow-upgrade

ee5242b

- ran flow-upgrade - switch React.Element<any> references to React.Node - switch all react imports to `* as React` and use the React.* for access to uniformly access both function and types - linted

[flow] flow-typed install

2062fca

[flow] flow-typed workaround marked libdef

399396d

flow-typed/flow-typed#1165

[flow] flow-upgrade ./test

3795a05

[flow] fix flow usage of WebkitTran*

11f09eb

[flow] type single-only children for transitions

7bf4a12

[flow] woohoo, resolved sticky Snackbar flow typing

7e039c2

[flow] more 53.1 typing

24e1cfc

[Card] flow fixes mui#7854

c12df8c

[flow] more flow 53.1

2b6482c

[flow] fixme for mui#7868

17d0aee

[flow] 53.1 ./examples

fe69ac7

[flow] weak type docs for 53.1

dd169dd

[flow] flow-typed workaround for flow-typed/flow-typed#1158

b7bd8cb

[flow] workaround for flow-typed/flow-typed#1158

2afae16

[flow] require Dialog element

6dfba1f

[flow] convert withStyles to flow

d3d903b

[flow] workaround brigand/babel-plugin-flow-react-proptypes#127

5cd6c8c

This isn’t a fix, it just gets past the error. I assume generated prop types are still invalid.

[flow] type TouchRipple and Ripple

4a342aa

[flow] type withTheme

7e5dbc0

[flow] type HOC withTheme

ad81ffa

[flow] bind hoc BaseProps

2ecc4fb

[flow] type withWidth

ca82d09

[flow] type Tabs

2946c46

[flow] correct requirements for HOC props

c2e8ced

[flow] 0.53.1 conversion - tests finally run with a few errors

77f21e5

[flow] FormControl children were tested as optional

bba1ce1

[Textarea] revert to target instead of currentTarget

a19dfcc

[docs] Fix missing props in css-in-js examples (mui#7867)

752818d

* [docs] Fix missing props in css-in-js examples `this.classes.root` wouldn't work - `this.props.classes.root' would. * Update css-in-js.md

rosskevin added flow labels Aug 23, 2017

rosskevin added 2 commits August 22, 2017 20:17

[flow] get docs working

8a474ba

[Tabs] fix flow change that broke tab movement

3fb649a

rosskevin added 2 commits August 22, 2017 21:03

[flow] reduce DefaultProps usage to the minimum necessary

bfa7ddd

[flow] type callback on ButtonBase

3a03192

oliviertassinari reviewed Aug 23, 2017

View reviewed changes

[docs] workaround react-docgen mui#7780

9e1f71f

rosskevin mentioned this pull request Aug 23, 2017

[flow] build size increase with 0.53 #7881

Closed

Temporary size limit increase due to mui#7881

e2dec75

rosskevin mentioned this pull request Aug 23, 2017

[docs] Remove flow from the demo folder #7882

Closed

rosskevin merged commit 470a825 into mui:v1-beta Aug 23, 2017

rosskevin added the breaking change Introduces changes that are not backward compatible. label Aug 23, 2017

rosskevin deleted the flow-531 branch August 24, 2017 03:16

Uh oh!

Uh oh!

Conversation

rosskevin commented Aug 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rosskevin commented Aug 23, 2017

Uh oh!

rosskevin commented Aug 23, 2017

Uh oh!

rosskevin commented Aug 23, 2017

Uh oh!

rosskevin commented Aug 23, 2017

Uh oh!

oliviertassinari Aug 23, 2017

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Aug 23, 2017

Choose a reason for hiding this comment

Uh oh!

rosskevin Aug 23, 2017

Choose a reason for hiding this comment

Uh oh!

rosskevin Aug 23, 2017

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Aug 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rosskevin Aug 23, 2017

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Aug 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Aug 23, 2017

Choose a reason for hiding this comment

Uh oh!

rosskevin Aug 23, 2017

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Aug 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rosskevin commented Aug 23, 2017

Uh oh!

oliviertassinari commented Aug 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rosskevin commented Aug 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rosskevin commented Aug 23, 2017

Uh oh!

oliviertassinari commented Aug 23, 2017

Uh oh!

rsolomon commented Aug 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rosskevin commented Aug 23, 2017 •

edited

Loading

oliviertassinari Aug 23, 2017 •

edited

Loading

oliviertassinari Aug 23, 2017 •

edited

Loading

oliviertassinari Aug 23, 2017 •

edited

Loading

oliviertassinari commented Aug 23, 2017 •

edited

Loading

rosskevin commented Aug 23, 2017 •

edited

Loading