[SelectField] Port SelectField component to v1#7632
Conversation
…not persisting for tab-focused SelectField'
…th form inputs, fixes dirty/clean events, and another shouldComponentUpdate
…/down arrow key handling for opening menu
| */ | ||
| disabled: PropTypes.bool, | ||
| /** | ||
| * Whether the label should be displayed in an error state. |
There was a problem hiding this comment.
"If true, the label will be displayed in an error state."
| */ | ||
| helperTextClassName: PropTypes.string, | ||
| /** | ||
| * Whether the label should be hidden when option is selected. |
There was a problem hiding this comment.
"If true, the label will be hidden when that option is selected."
| */ | ||
| InputLabelProps: PropTypes.object, | ||
| /** | ||
| * Passed as `inputProps` to the internal `<Input />` component. |
There was a problem hiding this comment.
"Properties applied to the Input element."
| */ | ||
| InputProps?: Object, | ||
| /** | ||
| * Use that property to pass a ref callback to the native input component. |
There was a problem hiding this comment.
Please could you standardise the wording of this one?
| */ | ||
| required?: boolean, | ||
| /** | ||
| * Use that property to pass a ref callback to the root component. |
| hideLabel, | ||
| id, | ||
| inputClassName, | ||
| InputClassName, |
There was a problem hiding this comment.
@kybarg Thanks for maintaining standards - if the consensus is to change this, best to do so consistently across all affected components.
|
@oliviertassinari @mbrookes I've updated this PR according to the latest requirements of the |
|
@kybarg right now I take it, |
|
@stunaz The main aim of this PR is to implement "native" |
|
Nice! |
|
@kybarg could you add an example using an object in the docs? |
|
@marcusjwhelan As I said this PR is more about bringing HTML |
|
@kybarg I'm using your PR as a starting point for the migration. Good job so far 👍. Also, don't be surprised if the API is different. I'm playing around some idea I have for now. |
|
@oliviertassinari please don't forget we're all waiting for it to migrate and it's all in beta. It's ok for me if it changes later, even a lot. Anyway, it's nothing compared to the migration to v1 :) |
|
Quick update, 20% done:
improved
|
|
Subscribing to this one! Thanks! |
|
@kybarg I guess I am confused by your comment. It is very easy to add object for an array of objects on select list. I have my own I made for a select table given dynamic data already. Would this select list be able to handle sending an array of objects? Why would I need to send the index? Can't you use the onChange event handler to capture the object in questions not needing an index? |
|
@marcusjwhelan It won't support an object. It will support an array for the multi select use case. It's brittle to serialize an object into an input field (that we need for taking advanage of the platform). |
|
@manuelmazzuola This component is aimed to support same feature as the original HTML |
|
looking forward to this change. our migration to the v1 depends on this feature... thanks for the nice work! |
12 participants
This PR includes all efforts from #7458 #6608 and #6301
Hope to push it forward a bit
Closes #5716