Skip to content

[Dialog] Also take fixed element into account#7239

Merged
oliviertassinari merged 1 commit into
mui:nextfrom
oliviertassinari:dialog-fixes
Jun 24, 2017
Merged

[Dialog] Also take fixed element into account#7239
oliviertassinari merged 1 commit into
mui:nextfrom
oliviertassinari:dialog-fixes

Conversation

@oliviertassinari

@oliviertassinari oliviertassinari commented Jun 24, 2017

Copy link
Copy Markdown
Member

Closes #7096

juin-24-2017 23-57-58

@oliviertassinari oliviertassinari added type: bug It doesn't behave as expected. scope: dialog Changes related to the dialog. v1.x.x labels Jun 24, 2017
@dsaco

dsaco commented Jul 28, 2017

Copy link
Copy Markdown

just now i upgrade to1.0.0-beta.2 (windows system , chrome browser)
it's remove popover and use menu
the problem is : if the body is long and has vertical scrollbar it's ok,
when the boby is short, add padding-right to body
every open cause the page layout change (a little strange)
follow is picture
short body normal
short body open menu
is this a right thing ? if you can understand this words , please reply me

@oliviertassinari

Copy link
Copy Markdown
Member Author

I'm not sure, it would be great to have a reproduction example.

@dsaco

dsaco commented Jul 28, 2017

Copy link
Copy Markdown

upload code take some times...
this is the demo sandbox

@oliviertassinari

Copy link
Copy Markdown
Member Author

@dsaco Sounds like an issue yes. It would be perfect to have a small reproduction example on codesandbox or webpackbin to further investigate.

@dsaco

dsaco commented Jul 29, 2017

Copy link
Copy Markdown

this is codesandbox url

@ghost ghost mentioned this pull request Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: dialog Changes related to the dialog. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dialog] AutoScrollBodyContent

2 participants