Skip to content

[Avatar] Port avatar component#4977

Merged
nathanmarks merged 2 commits into
mui:nextfrom
nathanmarks:avatar
Aug 13, 2016
Merged

[Avatar] Port avatar component#4977
nathanmarks merged 2 commits into
mui:nextfrom
nathanmarks:avatar

Conversation

@nathanmarks

@nathanmarks nathanmarks commented Aug 13, 2016

Copy link
Copy Markdown
Contributor

@nathanmarks
nathanmarks merged commit c18d1a6 into mui:next Aug 13, 2016
@nathanmarks
nathanmarks deleted the avatar branch August 13, 2016 17:28
Comment thread src/Avatar/Avatar.js
src: PropTypes.string,
/**
* srcSet desc
*/

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting in case these incomplete docblocks was unintentional.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the documentation is going to get a sweep over. Semi-intentional 😉

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolaiskogheim you have been pretty active around here lately, what's your story?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing more than that I use this library myself, and want to contribute back.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolaiskogheim have you had a chance to check out the next branch?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not yet. Things are moving fast in this project and it's sometimes difficult to keep up with what's happening and what's prioritised.
If there's something in particular you want help with regarding the next branch, I'd be happy to help out.

I'm on gitter btw.

@nathanmarks nathanmarks Aug 13, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to write some more about what is going on over there this weekend, it started as a demo/experiment for something smaller in scope and has evolved over the past few months

alexhayes added a commit to alexhayes/material-ui that referenced this pull request Sep 7, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this pull request Sep 7, 2017
@zannager zannager added the scope: avatar Changes related to the avatar. label Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: avatar Changes related to the avatar.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants