Repository navigation
[slider] Keep the decimals of a non-integer min when snapping to the step - #49635
Merged
Merged
Conversation
…step Co-Authored-By: Claude Opus 5.5 <[email protected]>
Deploy previewBundle size
PerformanceNo regressions in 32 benchmarks · ran 4m 39s · details Check out the code infra dashboard for more information about this PR. |
ZeeshanTamboli
added
type: bug
ZeeshanTamboli
approved these changes
Nov 9, 2026
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
Member
There was a problem hiding this comment.
Thanks for this. #49476 is the keyboard version of this rounding bug.
Contributor
|
Cherry-pick PRs will be created targeting branches: v9.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a non-integer
minand an integerstep, clicking or dragging the Slider lands on integers instead of the step grid. With<Slider min={0.5} max={10.5} step={1} />the valid values are 0.5, 1.5, 2.5, … (that's wheremarksdraws them, and what the arrow keys give), but a click at 30% sets4instead of3.5.roundValueToStepsnaps to… * step + minbut then rounds to the decimals ofsteponly, so the.5coming frommingets rounded away:material-ui/packages/mui-material/src/Slider/useSlider.ts
Lines 125 to 128 in e19b8a5
This rounds to the larger of the decimals of
stepandmin. Added a test underprop: stepthat fails onmasterwithexpected … 'aria-valuenow' with the value '3.5', but the value was '4'.I used Claude Code to write this change.
Before: https://stackblitz.com/edit/github-nb1ogvqc
After: https://stackblitz.com/edit/x9gwqxz6