Skip to content

[docs-infra] Run link checker during docs build instead of as separate CI step#48634

Merged
Janpot merged 1 commit into
mui:masterfrom
Janpot:revert-link-check-move
Jun 9, 2026
Merged

[docs-infra] Run link checker during docs build instead of as separate CI step#48634
Janpot merged 1 commit into
mui:masterfrom
Janpot:revert-link-check-move

Conversation

@Janpot

@Janpot Janpot commented Jun 8, 2026

Copy link
Copy Markdown
Member

Reverts the CI-orchestration part of #48088, which moved the broken-links checker out of the docs build into a standalone GitHub Actions step (pnpm docs:link-check).

The checker doesn't just validate links — it also writes export/material-ui/link-structure.json, which gets deployed to https://mui.com/material-ui/link-structure.json and is consumed by other products' link checkers (e.g. mui-x). Running it in a separate CI step meant the file was no longer produced inside the Netlify build's export/ output, so that URL started returning 404. Downstream checkers fetch it and throw on the non-OK response, breaking their docs builds — see mui/mui-x#22707.

This restores the prior behavior: pnpm link-check runs at the end of docs build (during the Netlify build), so link-structure.json is generated and deployed again. The separate CI step is removed.

The HTML-validation work from #48088 (the htmlValidate config and errorCount exit handling in reportBrokenLinks.mts) is intentionally kept — only the run-location change is reverted.

@code-infra-dashboard

Copy link
Copy Markdown

Deploy preview

https://deploy-preview-48634--material-ui.netlify.app/

Bundle size

Bundle Parsed size Gzip size
@mui/material 0B(0.00%) 0B(0.00%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/private-theming 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes


Check out the code infra dashboard for more information about this PR.

@Janpot Janpot added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Jun 8, 2026
@zannager
zannager requested a review from brijeshb42 June 8, 2026 15:53
@Janpot
Janpot merged commit 2802aba into mui:master Jun 9, 2026
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants