[material-ui][Autocomplete] Remove legacy aria-owns attribute for combobox#45302
Merged
ZeeshanTamboli merged 2 commits intoFeb 14, 2025
Merged
Conversation
ZeeshanTamboli
added
package: material-ui
scope: autocomplete
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
ZeeshanTamboli
marked this pull request as ready for review
February 14, 2025 08:50
ZeeshanTamboli
changed the title
aria-owns attributearia-owns attribute for combobox
aarongarciah
approved these changes
Feb 14, 2025
aarongarciah
left a comment
aarongarciah
left a comment
Member
There was a problem hiding this comment.
Just tested it and looks like the behavior and screen reader UX is intact.
Member
Author
|
@aarongarciah Should this be cherry-picked to v6? |
Member
|
@ZeeshanTamboli yeah, let's do it. |
ZeeshanTamboli
added
v6.x
needs cherry-pick
|
Cherry-pick PRs will be created targeting branches: v6.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking into issue #25365 and noticed that we can remove the legacy
aria-ownsattribute, as we already usearia-controls.From the spec https://www.w3.org/TR/wai-aria-1.2/#combobox:
The APG also states:
After reading the spec and docs, I believe we can close #25365 since it seems we fully support ARIA 1.2. Part of this was addressed in #30601—see #30601 (review)