[Menu][base-ui] Focus Menu Items on hover#40755
Merged
Merged
Conversation
michaldudak
added
scope: menu
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
zanivan
approved these changes
Jan 23, 2024
zanivan
left a comment
zanivan
left a comment
Collaborator
There was a problem hiding this comment.
It looks good! I added the fix to the CSS stylesheet too
github-actions
Bot
added
the
PR: out-of-date
DiegoAndai
reviewed
Jan 24, 2024
|
|
||
| const { getRootProps: getListRootProps, highlighted } = useListItem({ | ||
| item: id, | ||
| handlePointerOverEvents: true, |
Member
There was a problem hiding this comment.
We should add a parameter to useMenuItem to control this so the behavior can be modified. This is required for Material that has different hover and focus states.
github-actions
Bot
removed
the
PR: out-of-date
mostafa-rio
pushed a commit
to mostafa-rio/material-ui
that referenced
this pull request
Feb 3, 2024
Co-authored-by: zanivan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hovering over a menu item focuses it immediately, so we don't have a separate hover and focus states.
I changed the :focus-visible styles to :focus and removed the :hover styles.
Preview: https://deploy-preview-40755--material-ui.netlify.app/base-ui/react-menu/
Closes #40595
Closes #40597