[docs-infra] Reserve space for scrollbar#40749
Conversation
oliviertassinari
added
scope: docs-infra
Netlify deploy previewBundle size report |
|
What resolution are you using? I couldn't reproduce the layout shift here 🤔 Screen.Recording.2024-01-23.at.12.59.44.mov |
|
@zanivan You need a large enough screen to move from one page without a scrollbar to another with a scrollbar. |
zanivan
left a comment
zanivan
left a comment
There was a problem hiding this comment.
You need a large enough screen to move from one page without a scrollbar to another with a scrollbar.
It's really weird because there is clearly a layout shift in your video, but I couldn't reproduce it here in any way 😅
Tried to do so in the largest screen I have:
Screen.Recording.2024-01-23.at.19.11.46.mov
Anyway, I don't see any problem with adding this fix 👍
@zanivan Ah yes, it's because this https://www.notion.so/mui-org/Laptop-configuration-d306ca6120004d2e9034144e71c45b34?pvs=4#2bd404c6337443a0870ba1238293a457 |
oliviertassinari
changed the title
3 participants
Before, layout shift on page transiton
Screen.Recording.2024-01-23.at.01.38.17.mov
After, stable layout
Screen.Recording.2024-01-23.at.01.37.56.mov
I opened mui/base-ui#79 for what a better solution for this would be (it's annoying to see the scrollbar). This PR relies on a fix I introduced while back to support #17812 (comment)