[base-ui][Slider] Fix plain CSS demo's wrong keyboard behavior#40652
Merged
Conversation
mnajdova
added
docs
Netlify deploy previewBundle size report |
mnajdova
marked this pull request as ready for review
January 17, 2024 14:22
mnajdova
changed the title
danilo-leal
changed the title
Collaborator
|
Just a heads-up that there's a tangential PR of mine to this one that's also surfacing some problems regarding the focus-visible state styles (depending on whether it's using the native class or our own) → #40332 |
michaldudak
reviewed
Jan 17, 2024
Member
|
Indeed, it seems that just the plain CSS demo was affected. |
michaldudak
approved these changes
Jan 17, 2024
1 task
colmtuite
approved these changes
Jan 17, 2024
github-actions
Bot
added
the
PR: out-of-date
Signed-off-by: Marija Najdova <[email protected]>
github-actions
Bot
removed
the
PR: out-of-date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the wrong keyboard behavior, and updated the demo to match the style definition in the MUI System demo. Fixes #39792 (cc @michaldudak can you verify that the issue was happening only on the plain CSS demo?).
Steps to reproduce:
Preview link with the fix: https://deploy-preview-40652--material-ui.netlify.app/base-ui/react-slider/#introduction