Skip to content

[material-ui][InputBase] Add sx type to input , root slot#39569

Merged
ZeeshanTamboli merged 5 commits intomui:masterfrom
sai6855:inputbase-sx
Nov 2, 2023
Merged

[material-ui][InputBase] Add sx type to input , root slot#39569
ZeeshanTamboli merged 5 commits intomui:masterfrom
sai6855:inputbase-sx

Conversation

@sai6855
Copy link
Member

@sai6855 sai6855 commented Oct 22, 2023 •
edited
Loading

@sai6855 sai6855 marked this pull request as draft October 22, 2023 10:02
@sai6855 sai6855 changed the title Inputbase sx [InputBase][material-ui] Add sx type to slotProps Oct 22, 2023
@sai6855 sai6855 added type: bug It doesn't behave as expected. typescript package: material-ui labels Oct 22, 2023
@mui-bot
Copy link

mui-bot commented Oct 22, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-39569--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 7e6aa6f

@sai6855 sai6855 changed the title [InputBase][material-ui] Add sx type to slotProps [InputBase][material-ui] Add sx type to input , root slot Oct 22, 2023
@sai6855 sai6855 requested a review from DiegoAndai October 22, 2023 11:07
@sai6855 sai6855 marked this pull request as ready for review October 22, 2023 11:09
@mj12albert mj12albert mentioned this pull request Oct 24, 2023
Closed
11 tasks
ZeeshanTamboli
ZeeshanTamboli reviewed Nov 1, 2023
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this change could be applied to all components with slots and slotProps. Did you have a specific use case in mind for InputBase that prompted this fix?

@sai6855
Copy link
Member Author

sai6855 commented Nov 1, 2023

I believe this change could be applied to all components with slots and slotProps. Did you have a specific use case in mind for InputBase that prompted this fix?

Not specific use case, i stumbled upon this TS error while investigating one of the issues. Couldn't recall the exact issue

@sai6855
Copy link
Member Author

sai6855 commented Nov 1, 2023 •
edited
Loading

I believe this change could be applied to all components with slots and slotProps.

What do you think better action plan for this, fix all ts errors in 1 PR or individual PR for each component ?

@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Nov 2, 2023

I believe this change could be applied to all components with slots and slotProps.

What do you think better action plan for this, fix all ts errors in 1 PR or individual PR for each component ?

Let's not do this now. There will be lot of PRs. This is fine for now. We can tackle others when someone needs it.

@ZeeshanTamboli ZeeshanTamboli changed the title [InputBase][material-ui] Add sx type to input , root slot [material-ui][InputBase] Add sx type to input , root slot Nov 2, 2023
@ZeeshanTamboli ZeeshanTamboli merged commit a1cc186 into mui:master Nov 2, 2023
@mj12albert mj12albert mentioned this pull request Nov 2, 2023
Merged
1 task
@oliviertassinari oliviertassinari added the scope: text field Changes related to the text field. label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

@DiegoAndai DiegoAndai Awaiting requested review from DiegoAndai

Assignees

No one assigned

Labels

scope: text field Changes related to the text field. type: bug It doesn't behave as expected. typescript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sai6855 @mui-bot @ZeeshanTamboli @oliviertassinari @mj12albert

Comments