[Slider][material-next] Slider TS improvements#38021
Closed
DiegoAndai wants to merge 7 commits intomui:masterfrom
Closed
[Slider][material-next] Slider TS improvements#38021DiegoAndai wants to merge 7 commits intomui:masterfrom
DiegoAndai wants to merge 7 commits intomui:masterfrom
Conversation
Netlify deploy previewBundle size report |
This was referenced Jul 14, 2023
Member
Author
|
@oliviertassinari I was thinking of removing the default slots proptypes and exports, for example the default root slot proptypes and export. Joy UI's Slider does not have the default slots proptypes, should we follow that in Material as well? Is there a reason to keep them? |
Member
|
This was referenced Aug 12, 2023
Member
Author
|
PR got out of date as it has been on hold for a while. Closing as stale. We'll have to revisit this later this year while working on v7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on this comment: #37853 (comment)
Improve and fix slider types:
Slider.types.tsfile toSlider.tsxfile, fixing the slotProps not being properly type checked. This should've been done when migratingSlider.jstoSlider.tsx.Slider.types.ts. This should've been done when migratingSlider.jstoSlider.tsx.Slider.spec.tsxfileSlider.test.jstests toSlider.test.tsxCodesandbox example of slotProps type checking: https://codesandbox.io/s/slider-slotprops-type-check-shared-6rshpl