Skip to content

[docs-infra] Add analyticsTags to Algolia#37600

Merged
Janpot merged 1 commit into
mui:masterfrom
Janpot:analytics-tags
Jun 19, 2023
Merged

[docs-infra] Add analyticsTags to Algolia#37600
Janpot merged 1 commit into
mui:masterfrom
Janpot:analytics-tags

Conversation

@Janpot

@Janpot Janpot commented Jun 15, 2023

Copy link
Copy Markdown
Member

Add analyticsTags to enable filtering Algolia analytics by product. One of #16502.

@Janpot Janpot added the docs Improvements or additions to the documentation. label Jun 15, 2023
@Janpot
Janpot marked this pull request as ready for review June 15, 2023 16:58
@mui-bot

mui-bot commented Jun 15, 2023

Copy link
Copy Markdown

@Janpot
Janpot requested a review from oliviertassinari June 16, 2023 03:40
@oliviertassinari oliviertassinari added the scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). label Jun 17, 2023
@oliviertassinari oliviertassinari changed the title [docs] Add analyticsTags to Algolia [docs-infra] Add analyticsTags to Algolia Jun 17, 2023

@oliviertassinari oliviertassinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work, the data is sent:

Screenshot 2023-06-17 at 21 44 52

and then available in the UI:

Screenshot 2023-06-17 at 21 48 09

For MUI X, it will report with x-data-grid and x-date-pickers for the "product", I guess it's OK.

@alexfauquette alexfauquette left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to discover how algolia is added into the docs :)

@Janpot
Janpot merged commit 0e56ecc into mui:master Jun 19, 2023
@Janpot
Janpot deleted the analytics-tags branch June 19, 2023 07:58
@oliviertassinari

oliviertassinari commented Jul 1, 2023

Copy link
Copy Markdown
Member

A quick look at this, 2 weeks in, I believe we solved this issue recently, and we just start to get data as there is a lag to deploy the docs, and have users using the search to gather analytics:

Screenshot 2023-07-01 at 14 01 34

I will check again in 2 weeks to see how it looks.

@oliviertassinari oliviertassinari added the type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. label Jul 1, 2023
@oliviertassinari

Copy link
Copy Markdown
Member

I will check again in 2 weeks to see how it looks.

It seems all good, we are done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants