[TextField] Standardize onChange callback and remove valueLink#3699
Merged
Conversation
nathanmarks
force-pushed
the
textfield-updates
branch
from
March 15, 2016 13:16
76b265d to
df5805f
Compare
nathanmarks
force-pushed
the
textfield-updates
branch
from
March 15, 2016 13:18
df5805f to
8fce355
Compare
Contributor
Author
|
Force pushed a ninja change to my test... 😜 |
Contributor
Author
|
FYI, I'm tending to |
14 tasks
9 tasks
Member
|
That looks good to me 👍. |
Collaborator
|
Ok I'll merge this. Hopefully people won't complain 😆 😆 |
alitaheri
added a commit
that referenced
this pull request
Mar 17, 2016
[TextField] Standardize onChange callback and remove valueLink
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the value as the 2nd callback argument for
onChangeand removesvalueLinkas per #2957 and #2880