[internal] Move SearchIcons to docs src folder#34802
Merged
michaldudak merged 4 commits intomui:masterfrom Oct 18, 2022
Merged
Conversation
siriwatknp
added
the
internal
|
michaldudak
approved these changes
Oct 18, 2022
Member
michaldudak
left a comment
michaldudak
left a comment
There was a problem hiding this comment.
Looks great! Thanks for the fix!
Merged
Member
1 task
Member
Author
Hey, here is the fix > #34823. Will do a hotfix deployment. |
1 task
oliviertassinari
added a commit
that referenced
this pull request
Oct 23, 2022
This reverts commit 62af1d1.
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
This reverts commit 62af1d1.
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
This reverts commit 62af1d1.
oliviertassinari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #34454 is merged, the SearchIcon unmounts several times. I guess it has something to do with lazy loading because it remounts after JS has been downloaded.
This PR introduces a temporary fix (or maybe the right fix) by moving the
SearchIconsfrom the demo to the src component to unblock the release.Will do a deeper analysis after this.