[docs] Enforce correct git diff format#34765
Merged
Merged
Conversation
|
oliviertassinari
marked this pull request as ready for review
October 15, 2022 11:30
oliviertassinari
force-pushed
the
git-diff-format
branch
from
October 15, 2022 11:31
da670a7 to
8a50325
Compare
oliviertassinari
changed the title
oliviertassinari
changed the title
oliviertassinari
enabled auto-merge (squash)
October 21, 2022 15:01
oliviertassinari
disabled auto-merge
October 21, 2022 15:01
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce the git diff format with a custom rule for https://github.com/DavidAnson/markdownlint. It's simply about respecting
git showoutput. The new rule is inpackages/markdownlint-rule-mui/git-diff.js. I felt that I was frequently leaving comments about this aspect, this will save me time 😁.The discussion in mui/mui-x#6523 (comment) covers a bit more the value of it. It's a detail, but we are a UI company, people look up to us to care about these small details.