[internal] Improve the playground DX#34739
Merged
oliviertassinari merged 3 commits intoOct 14, 2022
Merged
Conversation
oliviertassinari
added
the
internal
oliviertassinari
force-pushed
the
improve-playground
branch
from
October 12, 2022 15:24
60ceb66 to
4316f96
Compare
oliviertassinari
force-pushed
the
improve-playground
branch
2 times, most recently
from
October 12, 2022 15:27
76bc527 to
bfad418
Compare
oliviertassinari
force-pushed
the
improve-playground
branch
from
October 12, 2022 15:31
bfad418 to
484ea14
Compare
LukasTy
approved these changes
Oct 14, 2022
LukasTy
left a comment
LukasTy
left a comment
Member
There was a problem hiding this comment.
It looks good and seems to solve the same cases we covered in mui-x repository.
Just a few suggestion for text improvements:
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index b0ebab1f24..3223108842 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -94,20 +94,22 @@ Changes to the docs will hot reload the site.
### Trying changes on the playground
-While we recommand to try your changes on the documentation site, it's not always ideal.
-You can face problems this way:
+While we recommend to try your changes on the documentation site—it's not always ideal.
+You might face following problems:
- updating the existing demos prevent you to work in isolation on a single instance of the component
- emptying an existing page to try your changes in isolation lead to a noisy `git diff`
- static linters will report issues that you might not care about.
-To solve these problems, you can use the playground:
+To solve these problems—you can use the playground:
-You can now access it locally http://localhost:3000/playground/.
+You can now access it locally: http://localhost:3000/playground/.
+
+You can create as many playgrounds as you want—they will be accessible under: `http://localhost:3000/playground/<file_name>`.
### How to increase the chance of being accepted?
oliviertassinari
enabled auto-merge (squash)
October 14, 2022 21:34
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
oliviertassinari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As promised #29423 (comment) 😁. The changes in this PR bring the following improvements: