[docs] Live demos by bharatkashyap · Pull Request #34454 · mui/material-ui

bharatkashyap · 2022-09-24T12:08:37Z

https://deploy-preview-34454--material-ui.netlify.app/material-ui/react-button/

Continuing the effort started in #24640, #30873 and #32107

…ions React Runner implementation - fix error spacing and blurred input text

…react-runner

siriwatknp

🤩 Awesome @bharatkashyap. I pushed some fix for Joy UI outlined demos, the rest looks good!

michaldudak · 2022-10-17T10:10:09Z

@bharatkashyap Now that this is merged, is #32107 still relevant, or should it be closed?

bharatkashyap · 2022-10-17T10:10:54Z

@bharatkashyap Now that this is merged, is #32107 still relevant, or should it be closed?

Should be good to close this now!

oliviertassinari · 2022-10-17T11:13:24Z

@nihgwu Thanks for all the help on this one! ❤️

joserodolfofreitas · 2022-10-17T11:34:05Z

Editing live feels great!
Well done!

michaldudak · 2022-10-17T12:19:44Z

An issue appeared that caused the e2e tests to fail on master (I'm not sure why they passed here): The Material icon browser (see https://deploy-preview-34454--material-ui.netlify.app/material-ui/material-icons/?selected=AcUnit) appears and disappeared a couple of times after loading.
@bharatkashyap do you have any idea what could cause such behavior or should I investigate it in more depth?
Is there a way to disable live edit functionality per demo?

bharatkashyap · 2022-10-17T15:16:50Z

An issue appeared that caused the e2e tests to fail on master (I'm not sure why they passed here): The Material icon browser (see https://deploy-preview-34454--material-ui.netlify.app/material-ui/material-icons/?selected=AcUnit) appears and disappeared a couple of times after loading. @bharatkashyap do you have any idea what could cause such behavior or should I investigate it in more depth? Is there a way to disable live edit functionality per demo?

I'm not exactly certain why this appears @michaldudak - I added a functionality to disable the editing and remove lazy loading in specific demos, but the issue seems to remain. I'm also not certain why the test passed here repeatedly.

michaldudak · 2022-10-18T07:46:16Z

@siriwatknp managed to fix it in #34802, all is well now.

This reverts commit b6e6b23.

oliviertassinari · 2022-10-23T14:37:36Z

I have reverted this PR in 19df4df, this PR broke too many things. We are also better of without live edit but with a single render of the demo.

The issues there we are aware of:

Each demo now renders 5 times instead of 1 time (x2 these numbers for dev mode with strict mode).
Broken demo: https://deploy-preview-34454--material-ui.netlify.app/versions, the process.env values are missing
Broken demo: https://deploy-preview-34454--material-ui.netlify.app/material-ui/material-icons/?selected=AcUnit it blinks
Broken demo: https://deploy-preview-34454--material-ui.netlify.app/joy-ui/getting-started/templates/ it doesn't render
Broken demo: https://deploy-preview-34454--material-ui.netlify.app/material-ui/getting-started/templates/ the process.env values are missing
Broken demo: https://deploy-preview-34454--material-ui.netlify.app/material-ui/react-drawer/#swipeable-edge
There is an extra line at the bottom: https://deploy-preview-34454--material-ui.netlify.app/material-ui/react-box/#the-sx-prop

This reverts commit 19df4df.

Co-authored-by: Neo Nie <[email protected]> Co-authored-by: Olivier Tassinari <[email protected]> Co-authored-by: Pedro Ferreira <[email protected]> Co-authored-by: siriwatknp <[email protected]>

This reverts commit b6e6b23.

bharatkashyap and others added 30 commits February 28, 2022 19:04

[docs] load dynamic editor editor and preview on first load

c642812

[docs] update lockfile

ece3fcc

PoC: support live editing

cc97ad3

use-editable

96a0735

on-demand imports

e0e232e

code reset

c0b403d

make jsxPreview editable

ca22bee

code convention

89400c1

standard name

75a0b59

don't build demos in loader

b133ef1

switch back to simple editor

507f02a

move error to bottom

6b88577

fix lint

3fd45cf

focus style

e4e32cd

debounce error

ca6452e

Merge branch 'master' into neo/react-runner

78c1a7a

improve a11y

723e84a

add hint

caf4539

Merge branch 'master' into neo/react-runner

47d224b

Merge branch 'master' into neo/react-runner

5a6bd79

React Runner PR - fix error spacing and blur message

4d499fe

Merge pull request mui#1 from apedroferreira/react-runner-fix-suggest…

dd39fae

…ions React Runner implementation - fix error spacing and blurred input text

fix scrolling in another way

e98beea

add back copy button

9017db6

Merge branch 'master' into neo/react-runner

322c611

prettier

2b85965

Merge branch 'master' into neo/react-runner

09acbac

Merge branch 'master' of https://github.com/mui/material-ui into neo/…

8b34ddc

…react-runner

add code copy hotkey

c54cfac

fix mobile style

cbaa918

revert Joy demo styles change

d062542

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 17, 2022

siriwatknp approved these changes Oct 17, 2022

View reviewed changes

michaldudak merged commit b6e6b23 into mui:master Oct 17, 2022

michaldudak mentioned this pull request Oct 17, 2022

[docs] Support live demo editing #32107

Closed

1 task

michaldudak mentioned this pull request Oct 17, 2022

v5.10.10 #34800

Merged

siriwatknp mentioned this pull request Oct 17, 2022

[internal] Move SearchIcons to docs src folder #34802

Merged

1 task

cherniavskii mentioned this pull request Oct 18, 2022

[internal] Upgrade monorepo mui/mui-x#6549

Merged

1 task

This was referenced Oct 20, 2022

Material UI Template links are not working #34819

Closed

[docs] Move Joy UI templates to src component #34836

Closed

oliviertassinari added a commit that referenced this pull request Oct 23, 2022

Revert "[docs] Live demos (#34454)"

19df4df

This reverts commit b6e6b23.

oliviertassinari added a commit to oliviertassinari/material-ui that referenced this pull request Oct 23, 2022

[docs] Live demos (mui#34454)

7f8321d

This reverts commit 19df4df.

oliviertassinari added a commit to oliviertassinari/material-ui that referenced this pull request Oct 23, 2022

[docs] Live demos (mui#34454)

a71f139

This reverts commit 19df4df.

oliviertassinari mentioned this pull request Oct 23, 2022

[docs] Live demos v2 #34870

Merged

oliviertassinari added a commit to oliviertassinari/material-ui that referenced this pull request Oct 30, 2022

[docs] Live demos (mui#34454)

a28da52

This reverts commit 19df4df.

oliviertassinari added a commit to oliviertassinari/material-ui that referenced this pull request Oct 30, 2022

[docs] Live demos (mui#34454)

b4bd228

This reverts commit 19df4df.

oliviertassinari added a commit to oliviertassinari/material-ui that referenced this pull request Nov 6, 2022

[docs] Live demos (mui#34454)

f761353

This reverts commit 19df4df.

oliviertassinari mentioned this pull request Nov 23, 2022

[docs] Make source code snippet editable #26476

Closed

1 task

feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022

Revert "[docs] Live demos (mui#34454)"

1998329

This reverts commit b6e6b23.

alexfauquette mentioned this pull request Aug 14, 2023

[docs-infra] Fix GoogleAnalytics missing event for code copy #38469

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[docs] Live demos#34454

[docs] Live demos#34454
michaldudak merged 57 commits intomui:masterfrom
bharatkashyap:live-demos

bharatkashyap commented Sep 24, 2022 •

edited by oliviertassinari

Loading

Uh oh!

siriwatknp left a comment

Uh oh!

michaldudak commented Oct 17, 2022

Uh oh!

bharatkashyap commented Oct 17, 2022

Uh oh!

oliviertassinari commented Oct 17, 2022

Uh oh!

joserodolfofreitas commented Oct 17, 2022

Uh oh!

michaldudak commented Oct 17, 2022 •

edited

Loading

Uh oh!

bharatkashyap commented Oct 17, 2022

Uh oh!

michaldudak commented Oct 18, 2022

Uh oh!

oliviertassinari commented Oct 23, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

bharatkashyap commented Sep 24, 2022 • edited by oliviertassinari Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

siriwatknp left a comment

Choose a reason for hiding this comment

Uh oh!

michaldudak commented Oct 17, 2022

Uh oh!

bharatkashyap commented Oct 17, 2022

Uh oh!

oliviertassinari commented Oct 17, 2022

Uh oh!

joserodolfofreitas commented Oct 17, 2022

Uh oh!

michaldudak commented Oct 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bharatkashyap commented Oct 17, 2022

Uh oh!

michaldudak commented Oct 18, 2022

Uh oh!

oliviertassinari commented Oct 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

bharatkashyap commented Sep 24, 2022 •

edited by oliviertassinari

Loading

michaldudak commented Oct 17, 2022 •

edited

Loading

oliviertassinari commented Oct 23, 2022 •

edited

Loading