[Grid] Add responsive direction and spacing props#26590
Merged
siriwatknp merged 9 commits intoJun 10, 2021
Conversation
|
Details of bundle changes (experimental) @material-ui/core: parsed: +0.04% , gzip: +0.09% |
oliviertassinari
changed the title
oliviertassinari
added
component: Grid
oliviertassinari
force-pushed
the
direction-spacing-responsive-props
branch
from
June 6, 2021 14:03
18cb6a6 to
a018eed
Compare
oliviertassinari
approved these changes
Jun 6, 2021
1 task
siriwatknp
reviewed
Jun 7, 2021
This comment has been minimized.
This comment has been minimized.
Member
|
@siriwatknp Great to have taken the initiative. If we could add a test case for the bug we fix, it would be even better |
eps1lon
requested changes
Jun 7, 2021
eps1lon
left a comment
eps1lon
left a comment
Member
There was a problem hiding this comment.
Just adding an explicit "request changes" until the other reviews are adressed.
github-actions
Bot
added
PR: out-of-date
siriwatknp
force-pushed
the
direction-spacing-responsive-props
branch
from
June 8, 2021 04:08
e45ac53 to
382824f
Compare
siriwatknp
reviewed
Jun 8, 2021
Member
|
@oliviertassinari I reverted the change I made and resolve conflict from #26559. I think it is good to go (also fix the type |
Member
|
@siriwatknp Looks great 👍 |
Member
|
@siriwatknp We could have updated this list with
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to have responsive direction and spacing props for Grid component.
Fixes: #6140
Preview: https://deploy-preview-26590--material-ui.netlify.app/components/grid/#responsive-values