Skip to content

[Grid] Add rowSpacing and columnSpacing props#26559

Merged
eps1lon merged 4 commits into
mui:nextfrom
likitarai1:grid-separate-row-col-spacing
Jun 7, 2021
Merged

[Grid] Add rowSpacing and columnSpacing props#26559
eps1lon merged 4 commits into
mui:nextfrom
likitarai1:grid-separate-row-col-spacing

Conversation

@likitarai1

@likitarai1 likitarai1 commented Jun 2, 2021

Copy link
Copy Markdown
Contributor

@mui-pr-bot

mui-pr-bot commented Jun 2, 2021

Copy link
Copy Markdown

Details of bundle changes (experimental)

@material-ui/core: parsed: +0.07% , gzip: +0.03%
@material-ui/lab: parsed: +0.08% , gzip: +0.06%

Generated by 🚫 dangerJS against d2339a7

@oliviertassinari oliviertassinari added the component: Grid The React component. label Jun 2, 2021
@oliviertassinari oliviertassinari changed the title Allow row and column spacing for grid separately [Grid] Add rowSpacing and columnSpacing props Jun 2, 2021
@oliviertassinari oliviertassinari added the type: new feature Expand the scope of the product to solve a new problem. label Jun 2, 2021
@oliviertassinari
oliviertassinari force-pushed the grid-separate-row-col-spacing branch from 8bd8e4e to 6b9d31c Compare June 6, 2021 11:14

@oliviertassinari oliviertassinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed new changes to:

  • Add visual test case
  • Add docs
  • Add types
  • Polish the CSS grid documentation, e.g. prepare the future live demos with the inline preview.

@siriwatknp siriwatknp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@oliviertassinari

This comment has been minimized.

@eps1lon

This comment has been minimized.

@oliviertassinari

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: Grid The React component. type: new feature Expand the scope of the product to solve a new problem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Grid] Allow different values for x and y spacing

5 participants