[Tabs] Update min & max width and remove minWidth media query#26458
Merged
Conversation
siriwatknp
added
breaking change
siriwatknp
commented
May 26, 2021
| justifyContent: 'center', | ||
| width: '100%', | ||
| flexDirection: 'column', | ||
| lineHeight: 1.25, |
Member
Author
There was a problem hiding this comment.
current wrapper inherit line-height: 1.75 which ~24px make 2 lines looks wierd. using 1.25 make it looks closer to the spec.
siriwatknp
commented
May 26, 2021
oliviertassinari
added
the
design: material
oliviertassinari
changed the title
min & max width and remove minWidth media querymin & max width and remove minWidth media query
oliviertassinari
approved these changes
May 27, 2021
2 tasks
1 task
Jack-Works
reviewed
Aug 25, 2021
| whiteSpace: 'normal', | ||
| textAlign: 'center', | ||
| [theme.breakpoints.up('sm')]: { | ||
| minWidth: 160, |
Contributor
There was a problem hiding this comment.
This change actually makes the minWidth smaller on up-sm. From 160px to 90px. Please add more detail on the migration page thanks.
Contributor
There was a problem hiding this comment.
Rollback to old behavior:
MuiTab: {
styleOverrides: {
root: {
// up-sm
'@media screen and (min-width: 600px)': {
minWidth: 160,
},
},
},
},
Member
There was a problem hiding this comment.
The described outcome is expected. I guess we can clarify https://next.material-ui.com/guides/migration-v4/#tab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #15824
The change follow material design spec
Preview: https://deploy-preview-26458--material-ui.netlify.app/components/tabs/