Skip to content

[core] Move StyledEngineProvider to @material-ui/core/styles#26265

Merged
mnajdova merged 10 commits into
mui:nextfrom
mnajdova:feat/move-StyledEngineProvider
May 13, 2021
Merged

[core] Move StyledEngineProvider to @material-ui/core/styles#26265
mnajdova merged 10 commits into
mui:nextfrom
mnajdova:feat/move-StyledEngineProvider

Conversation

@mnajdova

@mnajdova mnajdova commented May 12, 2021

Copy link
Copy Markdown
Member

BREAKING CHANGE v5

StyledEngineProvider location is changed. The previous location is deprecated, it will be removed in v5.beta.

-import StyledEngineProvider from '@material-ui/core/StyledEngineProvider ';
+import { StyledEngineProvider } from '@material-ui/core/styles';

Closes #23208
One of #20012

Comment thread packages/material-ui/src/index.d.ts Outdated
*/
export { default as StylesProvider } from './StyledEngineProvider';
export { default as StyledEngineProvider } from './StyledEngineProvider';
export { StyledEngineProvider } from './styles';

@mnajdova mnajdova May 12, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we are changing it a second time already 😞

@mui-pr-bot

mui-pr-bot commented May 12, 2021

Copy link
Copy Markdown

Details of bundle changes (experimental)

Generated by 🚫 dangerJS against 110fabd

Comment thread packages/material-ui/src/index.js
Comment thread packages/material-ui/src/styles/index.d.ts Outdated
Comment thread packages/material-ui/src/index.js Outdated
Comment thread packages/material-ui/src/index.js
@mnajdova
mnajdova marked this pull request as ready for review May 12, 2021 11:28
Comment thread packages/material-ui/src/StyledEngineProvider/index.js
Comment thread packages/material-ui/src/styles/index.js Outdated
@mnajdova
mnajdova requested a review from oliviertassinari May 12, 2021 12:47
@oliviertassinari oliviertassinari added the breaking change Introduces changes that are not backward compatible. label May 12, 2021

@oliviertassinari oliviertassinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ I have updated the PR's description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Introduces changes that are not backward compatible.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Module not found @material-ui/core/ThemeProvider when minimizing bundle size in create react app

3 participants