[Switch] Make color primary default#26182
Merged
Merged
Conversation
Member
|
Let’s update the examples so that we can fix the argos differences. |
Member
Author
|
@mnajdova The changes of argos I think are expected. Should the demonstrations in the examples show the primary color or secondary? For the ColorSwitches demo, green was corrected. |
vicasas
added
breaking change
Member
|
Ideally, we shouldn't have changes in argos. We should just do: -<Switch />
+<Switch color="secondary" />and -<Switch color="primary"/>
+<Switch /> |
mnajdova
reviewed
May 7, 2021
Member
I'm not so sure, the idea was that "primary" makes more sense. Would we send a contradicting message if the docs don't use it? |
Co-authored-by: Marija Najdova <[email protected]>
Co-authored-by: Olivier Tassinari <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes
[Switch] Make
color="primary"the default over secondary. This better matches the material design guidelines.One of the material design section #20012
Preview: https://deploy-preview-26182--material-ui.netlify.app/components/switches/