[core] Remove deprecated innerRef prop#26028
Merged
Merged
Conversation
m4theushw
changed the title
innerRefinnerRef prop
oliviertassinari
added
the
breaking change
oliviertassinari
approved these changes
Apr 28, 2021
eps1lon
pushed a commit
to siriwatknp/material-ui
that referenced
this pull request
Apr 29, 2021
[core] Remove deprecated innerRef prop (mui#26028)
siriwatknp
added a commit
that referenced
this pull request
May 12, 2021
* migrate to emotion * make styleProps optional * remove lint and add fn name * use yearButton from styles * revert types * [docs] Document all the colors available (#26015) * [Timeline] Add support for position override on items (#25974) * [core] Remove deprecated innerRef prop (#26028) [core] Remove deprecated innerRef prop (#26028) * [theme] Rename `createMuiTheme` to `createTheme` (#25992) * [pickers] Remove redundant aria-hidden (#26014) * [internal][pickers] Remove unused styles (#26023) * [pickers] Toggle mobile keyboard view in the same commit as the view changes (#26017) * [DateRangePicker] Fix not being opened on click (#26016) * Inline classes * type -> interface * sort asc * default props are private * remove uneccesary type casting * follow convention * trigger pipeline Co-authored-by: Anshuman Pandey <[email protected]> Co-authored-by: simonecervini <[email protected]> Co-authored-by: Matheus Wichman <[email protected]> Co-authored-by: Sebastian Silbermann <[email protected]> Co-authored-by: Olivier Tassinari <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES
Replace the
innerRefprop with therefprop. Refs are now automatically forwarded to the inner component.import * as React from 'react'; import { withStyles } from '@material-ui/core/styles'; const MyComponent = withStyles({ root: { backgroundColor: 'red', }, })(({ classes }) => <div className={classes.root} />); function MyOtherComponent(props) { const ref = React.useRef(); - return <MyComponent innerRef={ref} />; + return <MyComponent ref={ref} />; }Replace the
innerRefprop with therefprop. Refs are now automatically forwarded to the inner component.import * as React from 'react'; import { withTheme } from '@material-ui/core/styles'; const MyComponent = withTheme(({ theme }) => <div>{props.theme.direction}</div>); function MyOtherComponent(props) { const ref = React.useRef(); - return <MyComponent innerRef={ref} />; + return <MyComponent ref={ref} />; }Part of #20012