Skip to content

[Select] Remove labelWidth prop#26026

Merged
oliviertassinari merged 7 commits into
mui:nextfrom
m4theushw:remove-labelWidth
Apr 30, 2021
Merged

[Select] Remove labelWidth prop#26026
oliviertassinari merged 7 commits into
mui:nextfrom
m4theushw:remove-labelWidth

Conversation

@m4theushw

@m4theushw m4theushw commented Apr 28, 2021

Copy link
Copy Markdown
Collaborator

Breaking change

  • [Select] The labelWidth prop was removed. The label prop now fulfills the same purpose, using CSS layout instead of JavaScript measurement to render the gap in the outlined. The TextField already handles it by default.

    -<Select variant="outlined" labelWidth={20} />
    +<Select variant="outlined" label="Gender" />

Part of #20012
Closes #22799

Preview: https://deploy-preview-26026--material-ui.netlify.app/components/text-fields/

@mui-pr-bot

mui-pr-bot commented Apr 28, 2021

Copy link
Copy Markdown

Details of bundle changes

@material-ui/core: parsed: -0.10% 😍, gzip: -0.09% 😍

Generated by 🚫 dangerJS against 4d9d64f

Comment thread docs/src/pages/guides/migration-v4/migration-v4.md Outdated
Comment thread docs/src/pages/guides/migration-v4/migration-v4.md Outdated
@oliviertassinari oliviertassinari added breaking change Introduces changes that are not backward compatible. scope: select Changes related to the select. labels Apr 28, 2021
@m4theushw m4theushw changed the title [TextField][Select] Remove labelWidth prop [Select] Remove labelWidth prop Apr 28, 2021
Comment thread docs/src/pages/guides/migration-v4/migration-v4.md Outdated
Comment thread docs/src/pages/guides/migration-v4/migration-v4.md Outdated
@oliviertassinari
oliviertassinari merged commit 73b19d6 into mui:next Apr 30, 2021
@oliviertassinari

Copy link
Copy Markdown
Member

@m4theushw Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Introduces changes that are not backward compatible. scope: select Changes related to the select.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Select] Remove labelWidth prop

3 participants