Skip to content

[pickers] Migrate PickersDay to emotion#25995

Merged
siriwatknp merged 18 commits into
mui:nextfrom
siriwatknp:pickers-day-emotion
May 11, 2021
Merged

[pickers] Migrate PickersDay to emotion#25995
siriwatknp merged 18 commits into
mui:nextfrom
siriwatknp:pickers-day-emotion

Conversation

@siriwatknp

@siriwatknp siriwatknp commented Apr 27, 2021 •
edited by oliviertassinari
Loading

Copy link
Copy Markdown
Member

One of #24405

@siriwatknp siriwatknp mentioned this pull request Apr 27, 2021
Closed
@mui-pr-bot

mui-pr-bot commented Apr 27, 2021 •
edited
Loading

Copy link
Copy Markdown

Details of bundle changes (experimental)

@material-ui/lab: parsed: +0.30% , gzip: +0.22%

Generated by 🚫 dangerJS against 6cb9abc

eps1lon
eps1lon requested changes Apr 27, 2021
View reviewed changes

@eps1lon eps1lon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the original implementation logic. It should return different components not the same component with different props.

mnajdova
mnajdova reviewed Apr 27, 2021
View reviewed changes
Comment thread packages/material-ui-lab/src/PickersDay/PickersDay.tsx Outdated
@siriwatknp
siriwatknp force-pushed the pickers-day-emotion branch from f561a95 to 3532669 Compare April 28, 2021 02:22
@github-actions github-actions Bot mentioned this pull request Apr 28, 2021
Closed
@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 28, 2021
mnajdova
mnajdova requested changes Apr 28, 2021
View reviewed changes
Comment thread packages/material-ui-lab/src/PickersDay/PickersDay.tsx Outdated
Comment thread packages/material-ui-lab/src/PickersDay/PickersDay.tsx Outdated
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 28, 2021
eps1lon
eps1lon requested changes Apr 28, 2021
View reviewed changes
Comment thread packages/material-ui/src/styles/experimentalStyled.d.ts Outdated
@oliviertassinari oliviertassinari changed the title [Pickers] Migrate PickersDay to emotion [pickers] Migrate PickersDay to emotion Apr 28, 2021
@oliviertassinari oliviertassinari added the scope: pickers Changes related to the date/time pickers. label Apr 28, 2021
@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 29, 2021
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 29, 2021
@siriwatknp
siriwatknp requested review from eps1lon and mnajdova April 29, 2021 10:45
mnajdova
mnajdova reviewed Apr 29, 2021
View reviewed changes
Comment thread packages/material-ui-lab/src/PickersDay/PickersDay.tsx Outdated
mnajdova
mnajdova reviewed Apr 29, 2021
View reviewed changes
Comment thread packages/material-ui/src/styles/useThemeProps.d.ts
mnajdova
mnajdova reviewed May 11, 2021
View reviewed changes
Comment thread packages/material-ui-lab/src/PickersDay/pickersDayClasses.ts Outdated
mnajdova
mnajdova reviewed May 11, 2021
View reviewed changes
Comment thread packages/material-ui-lab/src/PickersDay/PickersDay.tsx Outdated
@siriwatknp
siriwatknp merged commit 68ea9e5 into mui:next May 11, 2021
@siriwatknp
siriwatknp deleted the pickers-day-emotion branch May 11, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnajdova mnajdova mnajdova approved these changes
@eps1lon eps1lon eps1lon approved these changes

Assignees

No one assigned

Labels

scope: pickers Changes related to the date/time pickers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@siriwatknp @mui-pr-bot @mnajdova @eps1lon @oliviertassinari