[Timeline] Migrate Timeline to emotion#25838
Merged
Merged
Conversation
|
@material-ui/lab: parsed: +0.11% , gzip: +0.04% |
mnajdova
reviewed
Apr 19, 2021
| { | ||
| name: 'MuiTimeline', | ||
| slot: 'Root', | ||
| // @ts-ignore TODO should fix the type in experimentalStyled |
Member
There was a problem hiding this comment.
It's great that we can spot issues like this by actually using it in TS. Let me know if you need some help with this. Probably these can be inferred from the props' props, but also allow generic, as I think sometimes we have additional or calculated props here.
Member
Author
There was a problem hiding this comment.
@mnajdova I fix as workaround by changing from string | object to Record<string, any>
siriwatknp
commented
Apr 21, 2021
mnajdova
reviewed
Apr 21, 2021
Comment on lines
+43
to
+47
|
|
||
| /** | ||
| * className applied to the root element. | ||
| */ | ||
| className?: string; |
Member
There was a problem hiding this comment.
This is weird, I was expecting it to already come for free with React.HTMLAttributes<HTMLUListElement
mnajdova
reviewed
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One chunk of #24405