Skip to content

[Timeline] Migrate TimelineItem to emotion#25822

Merged
mnajdova merged 8 commits into
mui:nextfrom
vicasas:feature/migrate-timeline-item-demo-to-emotion
Apr 19, 2021
Merged

[Timeline] Migrate TimelineItem to emotion#25822
mnajdova merged 8 commits into
mui:nextfrom
vicasas:feature/migrate-timeline-item-demo-to-emotion

Conversation

@vicasas

@vicasas vicasas commented Apr 18, 2021

Copy link
Copy Markdown
Member

One of #24405

@mui-pr-bot

mui-pr-bot commented Apr 18, 2021

Copy link
Copy Markdown

Details of bundle changes

Generated by 🚫 dangerJS against eae4428

Comment thread packages/material-ui-lab/src/TimelineItem/TimelineItem.js Outdated
@oliviertassinari oliviertassinari added the scope: timeline Changes related to the timeline. label Apr 18, 2021

@mnajdova mnajdova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cleanup needed with the context, otherwise looks good.

Comment thread packages/material-ui-lab/src/TimelineItem/TimelineItem.js Outdated
Comment thread packages/material-ui-lab/src/TimelineItem/TimelineItem.js Outdated
Comment thread packages/material-ui-lab/src/TimelineItem/TimelineItem.js Outdated
@vicasas

vicasas commented Apr 19, 2021

Copy link
Copy Markdown
Member Author

I will review this later.

@mnajdova mnajdova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've done some cleanup on the context as we don't need it anymore, otherwise it looked good.

@mnajdova
mnajdova merged commit 521e5a8 into mui:next Apr 19, 2021
@vicasas

vicasas commented Apr 19, 2021

Copy link
Copy Markdown
Member Author

I think i'm late 😆. Thank you as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: timeline Changes related to the timeline.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants