Skip to content

[Timeline] Migrate TimelineContent to emotion#25781

Merged
mnajdova merged 18 commits into
mui:nextfrom
siriwatknp:timeline-content-migration
Apr 16, 2021
Merged

[Timeline] Migrate TimelineContent to emotion#25781
mnajdova merged 18 commits into
mui:nextfrom
siriwatknp:timeline-content-migration

Conversation

@siriwatknp

@siriwatknp siriwatknp commented Apr 15, 2021

Copy link
Copy Markdown
Member

One of #24405

@mui-pr-bot

mui-pr-bot commented Apr 15, 2021

Copy link
Copy Markdown

Details of bundle changes

@material-ui/lab: parsed: +0.13% , gzip: +0.10%

Generated by 🚫 dangerJS against ecbd75b

@mnajdova mnajdova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of review :)

Comment thread packages/material-ui-lab/src/TimelineContent/TimelineContent.d.ts
Comment thread packages/material-ui-lab/src/TimelineContent/TimelineContent.js Outdated
Comment thread packages/material-ui-lab/src/TimelineContent/TimelineContent.js
Comment thread packages/material-ui-lab/src/TimelineContent/TimelineContent.js Outdated
Comment thread packages/material-ui-lab/src/TimelineContent/TimelineContent.js
Comment thread packages/material-ui-lab/src/TimelineContent/timelineContentClasses.js Outdated
Comment thread test/utils/describeConformance.js
@mnajdova mnajdova added the scope: timeline Changes related to the timeline. label Apr 15, 2021
@mnajdova mnajdova changed the title [TimelineContent] migrate to emotion [Timeline] Migrate TimelineContent to emotion Apr 15, 2021
Comment thread packages/material-ui-lab/src/TimelineContent/TimelineContent.js
Comment thread packages/material-ui-lab/src/TimelineContent/TimelineContent.js Outdated
Comment thread packages/material-ui-lab/src/TimelineContent/TimelineContent.js Outdated
Comment thread packages/material-ui-lab/src/TimelineContent/TimelineContent.test.js Outdated
@siriwatknp

siriwatknp commented Apr 16, 2021

Copy link
Copy Markdown
Member Author

@oliviertassinari @mnajdova I cannot find a way to fix this, need your helps. (works fine locally)

Trigger CI again fixed the error. 😊

image

@mnajdova mnajdova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @siriwatknp 👍

@mnajdova
mnajdova merged commit c9c69b5 into mui:next Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: timeline Changes related to the timeline.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants