Skip to content

[Tabs] Migrate TabPanel to emotion#25646

Merged
mnajdova merged 6 commits into
mui:nextfrom
tomasznguyen:migrate-tabpanel-emotion
Apr 8, 2021
Merged

[Tabs] Migrate TabPanel to emotion#25646
mnajdova merged 6 commits into
mui:nextfrom
tomasznguyen:migrate-tabpanel-emotion

Conversation

@tomasznguyen

@tomasznguyen tomasznguyen commented Apr 7, 2021 •
edited by oliviertassinari
Loading

Copy link
Copy Markdown
Contributor

One of #24405

Because TabPanel is a lab component, I have imported experimentalStyled and useThemeProps as follows:

import {
  experimentalStyled,
  unstable_useThemeProps as useThemeProps,
} from '@material-ui/core/styles';

Let me know if this is the correct way.

@tomasznguyen tomasznguyen changed the title migrate TabPanel to emotion [TabPanel] Migrate to emotion Apr 7, 2021
@mui-pr-bot

mui-pr-bot commented Apr 7, 2021 •
edited
Loading

Copy link
Copy Markdown

Details of bundle changes

@material-ui/lab: parsed: +0.09% , gzip: +0.07%

Generated by 🚫 dangerJS against 3d25092

@github-actions github-actions Bot mentioned this pull request Apr 7, 2021
Closed
mnajdova
mnajdova reviewed Apr 7, 2021
View reviewed changes
Comment thread packages/material-ui-lab/src/TabPanel/TabPanel.test.tsx Outdated
@tomasznguyen

This comment has been minimized.

Sign in to view
mnajdova
mnajdova reviewed Apr 7, 2021
View reviewed changes
Comment thread packages/material-ui-lab/src/TabPanel/TabPanel.test.tsx Outdated
mnajdova
mnajdova approved these changes Apr 7, 2021
View reviewed changes

@mnajdova mnajdova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@tomasznguyen

tomasznguyen commented Apr 7, 2021

Copy link
Copy Markdown
Contributor Author

You're welcome :)

@mnajdova
mnajdova merged commit 6e666a6 into mui:next Apr 8, 2021
@mnajdova mnajdova mentioned this pull request Apr 8, 2021
Closed
@mnajdova mnajdova added the scope: tabs Changes related to the tabs. label Apr 8, 2021
@mnajdova mnajdova changed the title [TabPanel] Migrate to emotion [Tabs] Migrate TabPanel to emotion Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees

No one assigned

Labels

scope: tabs Changes related to the tabs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomasznguyen @mui-pr-bot @mnajdova