Skip to content

[docs] Migrate TextField demos to emotion#25626

Merged
mnajdova merged 28 commits into
mui:nextfrom
vicasas:feature/migrate-textfield-demo-to-emotion
Apr 12, 2021
Merged

[docs] Migrate TextField demos to emotion#25626
mnajdova merged 28 commits into
mui:nextfrom
vicasas:feature/migrate-textfield-demo-to-emotion

Conversation

@vicasas

@vicasas vicasas commented Apr 5, 2021

Copy link
Copy Markdown
Member

Related to #16947

@mui-pr-bot

mui-pr-bot commented Apr 5, 2021

Copy link
Copy Markdown

No bundle size changes

Generated by 🚫 dangerJS against 28a97f3

@vicasas

vicasas commented Apr 5, 2021

Copy link
Copy Markdown
Member Author

Failure of argos is for visuals corrections.

Comment thread docs/src/pages/components/text-fields/CustomizedInputBase.tsx Outdated
@oliviertassinari oliviertassinari added scope: text field Changes related to the text field. docs Improvements or additions to the documentation. labels Apr 5, 2021
Comment thread docs/src/pages/components/text-fields/BasicTextFields.js
Comment thread docs/src/pages/components/text-fields/ColorTextFields.js Outdated
Comment thread docs/src/pages/components/text-fields/HelperTextAligned.tsx Outdated
<Box
sx={{
'& > :not(style)': {
m: 1,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
m: 1,
display: 'flex',
alignItems: 'center',

?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same as explained here

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does :not(style) mean?

Comment thread docs/src/pages/components/text-fields/LayoutTextFields.js
Comment thread docs/src/pages/components/text-fields/TextFieldSizes.tsx
Comment thread docs/src/pages/components/text-fields/ValidationTextFields.tsx

@oliviertassinari oliviertassinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the current demos could be broken down. There is a lot of content to scroll, probably too much, but it's a different topic.

@mnajdova mnajdova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mnajdova
mnajdova merged commit 85d2a51 into mui:next Apr 12, 2021
@vicasas
vicasas deleted the feature/migrate-textfield-demo-to-emotion branch April 12, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: text field Changes related to the text field.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants