Skip to content

[docs] Fix side nav scroll position#25619

Merged
oliviertassinari merged 2 commits into
mui:nextfrom
misaka3:fix_docs_drawer
Apr 4, 2021
Merged

[docs] Fix side nav scroll position#25619
oliviertassinari merged 2 commits into
mui:nextfrom
misaka3:fix_docs_drawer

Conversation

@misaka3

@misaka3 misaka3 commented Apr 4, 2021

Copy link
Copy Markdown
Contributor

@mui-pr-bot

mui-pr-bot commented Apr 4, 2021

Copy link
Copy Markdown

No bundle size changes

Generated by 🚫 dangerJS against f08d5e1

@oliviertassinari oliviertassinari changed the title Fix docs drawer when clicking. [docs] Fix docs drawer when clicking Apr 4, 2021
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation. type: bug It doesn't behave as expected. labels Apr 4, 2021
@oliviertassinari oliviertassinari changed the title [docs] Fix docs drawer when clicking [docs] Fix side nav scroll position Apr 4, 2021

@oliviertassinari oliviertassinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed an extra commit to isolate the two instances. We could notice a leak on mobile leading to a wrong behavior

@oliviertassinari
oliviertassinari merged commit ff2b314 into mui:next Apr 4, 2021
@oliviertassinari

Copy link
Copy Markdown
Member

It's much better!

@oliviertassinari oliviertassinari added the scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). label Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs] When clicking on the left drawer, ancre doesn't stay on the click

3 participants