Skip to content

[docs] Migrate Radio demos to emotion#25396

Merged
oliviertassinari merged 7 commits into
mui:nextfrom
vicasas:feature/migrate-radio-demo-to-emotion
Mar 18, 2021
Merged

[docs] Migrate Radio demos to emotion#25396
oliviertassinari merged 7 commits into
mui:nextfrom
vicasas:feature/migrate-radio-demo-to-emotion

Conversation

@vicasas

@vicasas vicasas commented Mar 17, 2021

Copy link
Copy Markdown
Member

The following demos of the Radio component were migrated:

  • Error radio
  • Customized radio
  • useRadioGroup

Related to #16947

@vicasas

vicasas commented Mar 17, 2021

Copy link
Copy Markdown
Member Author

@oliviertassinari Is it correct to do this for styles that make sense? Is there another way?

const StyledFormControlLabel = styled((props: StyledFormControlLabelProps) => (
  <FormControlLabel {...props} />
))(({ theme, checked }) => ({
  '.MuiFormControlLabel-label': checked && {
    color: theme.palette.secondary.main,
  },
}));

@mui-pr-bot

mui-pr-bot commented Mar 17, 2021

Copy link
Copy Markdown

No bundle size changes

Generated by 🚫 dangerJS against efc04ca

@vicasas

vicasas commented Mar 17, 2021

Copy link
Copy Markdown
Member Author

This failed for timeout. Run again CI please.

@oliviertassinari oliviertassinari added scope: radio Changes related to the radio. docs Improvements or additions to the documentation. labels Mar 17, 2021
@oliviertassinari
oliviertassinari force-pushed the feature/migrate-radio-demo-to-emotion branch from 4206e6d to 05175c6 Compare March 18, 2021 00:20

@oliviertassinari oliviertassinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread docs/src/pages/components/radio-buttons/CustomizedRadios.js
@oliviertassinari
oliviertassinari merged commit 5fb2a24 into mui:next Mar 18, 2021
@oliviertassinari

Copy link
Copy Markdown
Member

I have used the fix of the checkbox PR and applied it here. We are good :)

@vicasas

vicasas commented Mar 18, 2021

Copy link
Copy Markdown
Member Author

@oliviertassinari I could not replicate it here, my day was full. Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: radio Changes related to the radio.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants