Skip to content

[docs] Migrate Checkbox demos to emotion#25394

Merged
oliviertassinari merged 13 commits into
mui:nextfrom
vicasas:feature/migrate-checkbox-demo-to-emotion
Mar 18, 2021
Merged

[docs] Migrate Checkbox demos to emotion#25394
oliviertassinari merged 13 commits into
mui:nextfrom
vicasas:feature/migrate-checkbox-demo-to-emotion

Conversation

@vicasas

@vicasas vicasas commented Mar 17, 2021

Copy link
Copy Markdown
Member

The following demos of the Checkbox component were migrated:

  • Indeterminate
  • Label
  • FormGroup
  • Customized checkbox

Related to #16947

@mui-pr-bot

mui-pr-bot commented Mar 17, 2021

Copy link
Copy Markdown

No bundle size changes

Generated by 🚫 dangerJS against 6e51db9

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation. label Mar 17, 2021
Comment thread docs/src/pages/components/checkboxes/CustomizedCheckbox.tsx

@oliviertassinari oliviertassinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The keyboard focus visible on the customizaton demo is broken

@vicasas

vicasas commented Mar 18, 2021

Copy link
Copy Markdown
Member Author

The keyboard focus visible on the customizaton demo is broken

Resolved

@oliviertassinari oliviertassinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have used the opportunity to breakdown the existing demos. Much better :)

@vicasas

vicasas commented Mar 18, 2021

Copy link
Copy Markdown
Member Author

I have used the opportunity to breakdown the existing demos. Much better :)

Sure! by default it uses the primary. I will be more careful in the next 🎉

@oliviertassinari

oliviertassinari commented Mar 18, 2021

Copy link
Copy Markdown
Member

I will be more careful in the next

@vicasas I didn't see any mistake in the migration. Well done. The changes I have done were to further improve the page.

@oliviertassinari
oliviertassinari merged commit ea2bd5a into mui:next Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants