Skip to content

[docs] Migrate Chip demos to emotion#25268

Merged
oliviertassinari merged 5 commits into
mui:nextfrom
vicasas:feature/migrate-chip-demo-to-emotion
Mar 9, 2021
Merged

[docs] Migrate Chip demos to emotion#25268
oliviertassinari merged 5 commits into
mui:nextfrom
vicasas:feature/migrate-chip-demo-to-emotion

Conversation

@vicasas

@vicasas vicasas commented Mar 8, 2021

Copy link
Copy Markdown
Member

The following demos of the Chip component were migrated:

  • Chip
  • Outlined chip
  • Array chip
  • Small chip (Filled and Outlined)

Related to #16947

@mui-pr-bot

mui-pr-bot commented Mar 8, 2021 •
edited
Loading

Copy link
Copy Markdown

No bundle size changes

Generated by 🚫 dangerJS against f577aae

@oliviertassinari oliviertassinari added scope: chip Changes related to the chip. docs Improvements or additions to the documentation. labels Mar 8, 2021
oliviertassinari
oliviertassinari approved these changes Mar 8, 2021
View reviewed changes

@oliviertassinari oliviertassinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side note. We will need to breakdown the chips demo, to be more focused. There are too convoluted currently.

@vicasas

vicasas commented Mar 8, 2021

Copy link
Copy Markdown
Member Author

@oliviertassinari I'll keep it in mind. Right now something like this occurs to me...

Basic Chip or Contained Chip

  • Default Chip, Primary Chip, Secondary Chip, Disabled Chip (Whit Button demo)

Clickable Chip

  • Demo...

Avatar Chip

  • Demo...

Icon Chip

  • Demo...

Deletable Chip

  • Demo...

@oliviertassinari

oliviertassinari commented Mar 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Regarding the breakdown, it feels like the current demos were built for the visual regressions tests, not the developers. We could move them to the test/regressions. For the split, I think that we should aim to have them small enough for the inline preview. I also think that we can do like the the text-field, have the outlined and filled variant documented in the same demo once the notion of variant has been introduced.

@oliviertassinari
oliviertassinari merged commit 5808a69 into mui:next Mar 9, 2021
@vicasas

vicasas commented Mar 10, 2021

Copy link
Copy Markdown
Member Author

Regarding the breakdown

There is an issue associated with this or it is related to it?

@oliviertassinari

oliviertassinari commented Mar 10, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

There is an issue associated with this or it is related to it?

@vicasas The closest would be #22484

@vicasas vicasas mentioned this pull request Mar 14, 2021
Closed
89 tasks
@vicasas vicasas mentioned this pull request Apr 10, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees

No one assigned

Labels

docs Improvements or additions to the documentation. scope: chip Changes related to the chip.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vicasas @mui-pr-bot @oliviertassinari