Skip to content

[docs] Migrate Fab demos to emotion#25251

Merged
oliviertassinari merged 10 commits into
mui:nextfrom
vicasas:feature/migrate-fab-demo-to-emotion
Mar 7, 2021
Merged

[docs] Migrate Fab demos to emotion#25251
oliviertassinari merged 10 commits into
mui:nextfrom
vicasas:feature/migrate-fab-demo-to-emotion

Conversation

@vicasas

@vicasas vicasas commented Mar 7, 2021

Copy link
Copy Markdown
Member

The following demos of the Fab component were migrated:

  • Basic fab
  • Sizes fab
  • Animation fab

Related to #16947

@mui-pr-bot

mui-pr-bot commented Mar 7, 2021

Copy link
Copy Markdown

No bundle size changes

Generated by 🚫 dangerJS against 7af1e5f

@oliviertassinari oliviertassinari added component: Fab The React component. docs Improvements or additions to the documentation. labels Mar 7, 2021

@oliviertassinari oliviertassinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have spent 10 minutes pushing it further. You can review each individual commit.

@vicasas

vicasas commented Mar 7, 2021

Copy link
Copy Markdown
Member Author

@oliviertassinari Thanks for all the feedback, I read each one of them and I will try to make the demos smaller. He did not know what made the code to be seen or hidden, now I understand that it depends on the length of the example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: Fab The React component. docs Improvements or additions to the documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants