Skip to content

[docs] Migrate Divider demos to emotion#25145

Merged
oliviertassinari merged 12 commits into
mui:nextfrom
vicasas:feature/migrate-divider-demo-to-emotion
Mar 2, 2021
Merged

[docs] Migrate Divider demos to emotion#25145
oliviertassinari merged 12 commits into
mui:nextfrom
vicasas:feature/migrate-divider-demo-to-emotion

Conversation

@vicasas

@vicasas vicasas commented Feb 28, 2021

Copy link
Copy Markdown
Member

The following demos of the Button component were migrated:

  • List dividers
  • Inset dividers
  • Subheader dividers
  • Middle dividers
  • Vertical dividers

Related to #16947

@mui-pr-bot

mui-pr-bot commented Feb 28, 2021 •
edited
Loading

Copy link
Copy Markdown

No bundle size changes

Generated by 🚫 dangerJS against 808f450

@vicasas

vicasas commented Feb 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

@oliviertassinari I still have to migrate the following demos, but first I have some doubts

  • Vertical with text
  • Dividers with text
  1. How can I do this without problems? ...(theme) => ...theme.typography.body2 in the sx props
  2. In the Vertical divider demo I went from 4px to 16px using theme.shape.borderRadius. Do we leave it like that or do I place 4px direct?

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation. label Feb 28, 2021
oliviertassinari
oliviertassinari reviewed Feb 28, 2021
View reviewed changes
Comment thread docs/src/pages/components/dividers/ListDividers.js Outdated
oliviertassinari
oliviertassinari reviewed Feb 28, 2021
View reviewed changes
Comment thread docs/src/pages/components/dividers/ListDividers.tsx Outdated
oliviertassinari
oliviertassinari reviewed Feb 28, 2021
View reviewed changes
Comment thread docs/src/pages/components/dividers/VerticalDividers.tsx Outdated
oliviertassinari
oliviertassinari reviewed Feb 28, 2021
View reviewed changes
Comment thread docs/src/pages/components/dividers/VerticalDividers.tsx Outdated
oliviertassinari
oliviertassinari reviewed Feb 28, 2021
View reviewed changes
Comment thread docs/src/pages/components/dividers/VerticalDividers.tsx Outdated
oliviertassinari
oliviertassinari reviewed Feb 28, 2021
View reviewed changes
Comment thread docs/src/pages/components/dividers/VerticalDividers.tsx Outdated
oliviertassinari
oliviertassinari reviewed Feb 28, 2021
View reviewed changes
Comment thread docs/src/pages/components/dividers/SubheaderDividers.tsx Outdated
oliviertassinari
oliviertassinari reviewed Feb 28, 2021
View reviewed changes
Comment thread docs/src/pages/components/dividers/SubheaderDividers.tsx Outdated
oliviertassinari
oliviertassinari reviewed Feb 28, 2021
View reviewed changes
Comment thread docs/src/pages/components/dividers/SubheaderDividers.tsx Outdated
oliviertassinari
oliviertassinari requested changes Feb 28, 2021
View reviewed changes

@oliviertassinari oliviertassinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a quick look, we can apply the same comments multiple times

@vicasas

vicasas commented Feb 28, 2021

Copy link
Copy Markdown
Member Author

@oliviertassinari Thanks for the comments, I'll check them later. I continue with the question of point 1 that I comment above.

@oliviertassinari

oliviertassinari commented Feb 28, 2021

Copy link
Copy Markdown
Member
  1. https://next.material-ui.com/system/typography/#variant
  2. https://next.material-ui.com/system/borders/#border-radius

oliviertassinari
oliviertassinari approved these changes Mar 2, 2021
View reviewed changes

@oliviertassinari oliviertassinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed an update to further shorthen the demos

@oliviertassinari
oliviertassinari merged commit 4b2661d into mui:next Mar 2, 2021
@oliviertassinari

oliviertassinari commented Mar 2, 2021

Copy link
Copy Markdown
Member

Thanks

@github-actions github-actions Bot mentioned this pull request Mar 2, 2021
Closed
@vicasas

vicasas commented Mar 2, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

thanks to you, it was a pleasure 😁

@github-actions github-actions Bot mentioned this pull request Mar 2, 2021
Closed
@vicasas vicasas mentioned this pull request Mar 14, 2021
Closed
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees

No one assigned

Labels

docs Improvements or additions to the documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vicasas @mui-pr-bot @oliviertassinari