Skip to content

[Tabs] Change the default indicatorColor and textColor prop values to "primary"#25063

Merged
oliviertassinari merged 14 commits into
mui:nextfrom
Dripcoding:tabs-improve-color-management
Feb 24, 2021
Merged

[Tabs] Change the default indicatorColor and textColor prop values to "primary"#25063
oliviertassinari merged 14 commits into
mui:nextfrom
Dripcoding:tabs-improve-color-management

Conversation

@Dripcoding

@Dripcoding Dripcoding commented Feb 23, 2021 •
edited by oliviertassinari
Loading

Copy link
Copy Markdown
Contributor

Breaking changes

  • [Tabs] Change the default indicatorColor and textColor prop values to "primary".
    This is done to match the most common use cases with Material Design.

    -<Tabs />
+<Tabs indicatorColor="secondary" textColor="inherit" />

@mui-pr-bot

mui-pr-bot commented Feb 23, 2021 •
edited
Loading

Copy link
Copy Markdown

Details of bundle changes

Generated by 🚫 dangerJS against 07c4a4d

@github-actions github-actions Bot mentioned this pull request Feb 23, 2021
Closed
@Dripcoding Dripcoding changed the title [Tabs] Change defaults for textColor and indicatorColor props [TextField] Change defaults for textColor and indicatorColor props Feb 23, 2021
@Dripcoding Dripcoding changed the title [TextField] Change defaults for textColor and indicatorColor props [Tabs] Change defaults for textColor and indicatorColor props Feb 23, 2021
@oliviertassinari oliviertassinari added breaking change Introduces changes that are not backward compatible. scope: tabs Changes related to the tabs. labels Feb 23, 2021
oliviertassinari
oliviertassinari approved these changes Feb 24, 2021
View reviewed changes

@oliviertassinari oliviertassinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have push changes to improve the demos of the tabs; I have been keen on doing them for a long long time :)

@Dripcoding

Dripcoding commented Feb 24, 2021

Copy link
Copy Markdown
Contributor Author

I have push changes to improve the demos of the tabs; I have been keen on doing them for a long long time

Nice! The changes look good :]

@oliviertassinari oliviertassinari changed the title [Tabs] Change defaults for textColor and indicatorColor props [Tabs] Change the default indicatorColor and textColor prop values to "primary" Feb 24, 2021
@oliviertassinari
oliviertassinari merged commit b0d77d0 into mui:next Feb 24, 2021
@oliviertassinari

oliviertassinari commented Feb 24, 2021

Copy link
Copy Markdown
Member

@Dripcoding Thanks, a great step forward for the tabs components.

watiko added a commit to watiko/material-ui that referenced this pull request Jun 9, 2021
@watiko
[DateTimePicker] Follow Tabs change
2740db4 
ref: mui#25063
@watiko watiko mentioned this pull request Jun 9, 2021
Closed
1 task
@oliviertassinari oliviertassinari mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes
@eps1lon eps1lon eps1lon approved these changes
@mbrookes mbrookes Awaiting requested review from mbrookes

Assignees

No one assigned

Labels

breaking change Introduces changes that are not backward compatible. scope: tabs Changes related to the tabs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Tabs] Improve color management

4 participants

@Dripcoding @mui-pr-bot @oliviertassinari @eps1lon