[Table] Migrate TableBody to emotion#24703
Conversation
|
@material-ui/core: parsed: +0.08% , gzip: +0.06% |
| @@ -0,0 +1,7 @@ | |||
| import { TableBodyClassKey } from './TableBody'; | |||
|
|
|||
| declare const tableBodyClasses: Record<TableBodyClassKey, string>; | |||
There was a problem hiding this comment.
I'm not sure that it will be the way forward, at least, we haven't yet decided with #24736 (comment).
There was a problem hiding this comment.
Ah apologizes, I've missed that conversation, I thought the PR was merged. In my opinion, it makes sense that we use the props.classes the most, as far as I remember that was the first proposal in the PR. I don't mind if we use the ComponentClassesKeys, but we will have the pseudo keys there as well, which may be misleading, as the ComponentClassesKeys are used for the stylesOverrides in the theme. I'd say we shouldn't block the open migration PRs because of this anyway, as we will anyway need to update the classes in all components once we decide on the best option we will have.
4 participants
#24405