Skip to content

[Checkbox] Migrate to emotion#24702

Merged
oliviertassinari merged 10 commits into
mui:nextfrom
natac13:checkbox-emotion
Feb 9, 2021
Merged

[Checkbox] Migrate to emotion#24702
oliviertassinari merged 10 commits into
mui:nextfrom
natac13:checkbox-emotion

Conversation

@natac13

@natac13 natac13 commented Jan 30, 2021

Copy link
Copy Markdown
Contributor

#24405

@mui-pr-bot

mui-pr-bot commented Jan 30, 2021

Copy link
Copy Markdown

@material-ui/core: parsed: +0.07% , gzip: +0.03%

Details of bundle changes

Generated by 🚫 dangerJS against b13b4e6

@natac13

natac13 commented Jan 30, 2021

Copy link
Copy Markdown
Contributor Author

@oliviertassinari oliviertassinari added the scope: checkbox Changes related to the checkbox. label Jan 30, 2021
@natac13

natac13 commented Jan 30, 2021

Copy link
Copy Markdown
Contributor Author

I think the failing test just need to be re-run.

@vicasas

vicasas commented Jan 30, 2021

Copy link
Copy Markdown
Member

Maybe for the first failed test you are missing themeVariants in the test file skip. I previously had a similar error and solved it using this.

@natac13

natac13 commented Jan 30, 2021

Copy link
Copy Markdown
Contributor Author

I do not think these test have to do with the changes I have made. I could be wrong. But they have been failing intermittently

Ill add it and find out though thanks for the help.
Update:
Just checked again and I do not see those errors.

@oliviertassinari

Copy link
Copy Markdown
Member

@natac13 We could in theory treat indeterminate as the other pseudo-classes. However, the LinearProgress already uses this name. It would create a conflict. For now, I think that we can focus on the migration :)

@oliviertassinari
oliviertassinari merged commit 5f4b5cd into mui:next Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: checkbox Changes related to the checkbox.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants