[Table] Migrate TableCell to emotion#24663
Merged
Merged
Conversation
|
@material-ui/core: parsed: +0.21% , gzip: +0.14% |
Member
|
See #24658 (comment) for fixing the test error |
1 task
natac13
force-pushed
the
table-cell-emotion
branch
from
January 30, 2021 15:08
29f46e1 to
7f509aa
Compare
oliviertassinari
force-pushed
the
table-cell-emotion
branch
from
February 12, 2021 20:46
8f0a563 to
5d74d78
Compare
Member
|
Regarding performance. v4 v5 We had identified in the past, how moving from withStyles to makeStyle would yield a +10% in performance. So the new approach is close to x2 slower. On paper, it still has the potential to be faster:
|
Member
|
If it really becomes an issue, we can spend time investigating workarounds, the |
Member
|
I get different perf results in the benchmark: #24892. The difference between v4 and v5 is smaller than I thought. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#24405