Skip to content

[Card] Migrate CardActions to emotion#24604

Merged
mnajdova merged 3 commits into
mui:nextfrom
vicasas:feature/cardactions-migrate-emotion
Jan 25, 2021
Merged

[Card] Migrate CardActions to emotion#24604
mnajdova merged 3 commits into
mui:nextfrom
vicasas:feature/cardactions-migrate-emotion

Conversation

@vicasas

@vicasas vicasas commented Jan 24, 2021

Copy link
Copy Markdown
Member

One of #24405

💡 In which scenario should disableSpacing work? doing the migration I realized that it does not work, this came from before.

@vicasas vicasas changed the title feat: Migrate to emotion [Card] Migrate CardActions to emotion Jan 24, 2021
@mui-pr-bot

mui-pr-bot commented Jan 24, 2021

Copy link
Copy Markdown

@material-ui/core: parsed: +0.12% , gzip: +0.11%

Details of bundle changes

Generated by 🚫 dangerJS against 33fbb9a

@oliviertassinari

Copy link
Copy Markdown
Member

@vicasas Could you look into the failing test case?

@vicasas

vicasas commented Jan 25, 2021

Copy link
Copy Markdown
Member Author

@oliviertassinari The test is corrected, but I don't understand the difference between

-skip: ['componentProp''],
+skip: ['componentProp', 'componentsProp'], 

@mnajdova
mnajdova merged commit 1842ce8 into mui:next Jan 25, 2021
natac13 pushed a commit to natac13/material-ui that referenced this pull request Jan 25, 2021
eps1lon pushed a commit to eps1lon/material-ui that referenced this pull request Jan 26, 2021
@vicasas
vicasas deleted the feature/cardactions-migrate-emotion branch April 17, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: card Changes related to the card.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants