Skip to content

[List] Migrate ListItemText to emotion#24602

Merged
mnajdova merged 20 commits into
mui:nextfrom
natac13:listitemtext-emotion
Jan 25, 2021
Merged

[List] Migrate ListItemText to emotion#24602
mnajdova merged 20 commits into
mui:nextfrom
natac13:listitemtext-emotion

Conversation

@natac13

@natac13 natac13 commented Jan 24, 2021

Copy link
Copy Markdown
Contributor

3 tests are still failing... 😞

#24405

@mui-pr-bot

mui-pr-bot commented Jan 24, 2021

Copy link
Copy Markdown

@material-ui/core: parsed: +0.17% , gzip: +0.14%

Details of bundle changes

Generated by 🚫 dangerJS against 1e27d02

@oliviertassinari oliviertassinari changed the title [ListItemText] Migrate to emotion [List] Migrate ListItemText to emotion Jan 24, 2021
@oliviertassinari oliviertassinari added the scope: list Changes related to the list label Jan 24, 2021
@oliviertassinari

Copy link
Copy Markdown
Member

@natac13 Could you look into the failing test case?

Comment thread packages/material-ui/src/ListItemText/ListItemText.js Outdated
Comment thread packages/material-ui/src/ListItemText/ListItemText.js Outdated
Comment thread packages/material-ui/src/ListItemText/ListItemText.js Outdated
Comment thread packages/material-ui/src/ListItemText/ListItemText.js Outdated
Comment thread packages/material-ui/src/ListItemText/ListItemText.js Outdated
Comment thread packages/material-ui/src/ListItemText/ListItemText.js Outdated
Comment thread packages/material-ui/src/ListItemText/ListItemText.js Outdated
Comment thread packages/material-ui/src/ListItemText/ListItemText.js Outdated
@mnajdova

Copy link
Copy Markdown
Member

3 tests are still failing... 😞

@natac13 there was a type on the overridesResolver - see 811427d

@natac13

natac13 commented Jan 25, 2021

Copy link
Copy Markdown
Contributor Author

Thank you, sorry I was not able to see it. I did get the muiName typo but you beat me to it. lol

I'll pick another component and try again.

@mnajdova

mnajdova commented Jan 25, 2021

Copy link
Copy Markdown
Member

Thank you, sorry I was not able to see it. I did get the muiName typo but you beat me to it. lol

No worries, took me some time to see the typo too :)

Comment thread packages/material-ui/src/ListItemText/ListItemText.js Outdated
@mnajdova
mnajdova merged commit 2a0a58e into mui:next Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: list Changes related to the list

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants