[TextField] Prepare removal of labelWidth prop#24595
Conversation
391d8b2 to
782a843
Compare
782a843 to
6b146ef
Compare
eps1lon
left a comment
There was a problem hiding this comment.
I don't understand the purpose of this. Why not do the breaking change in one go?
|
I didn't have the bandwidth to handle the breaking change at that point. So I went with the simplest changes. |
|
But why roll this breaking change out partially? We never do this. Especially because it leaves code in an inconsistent state where we still use the old prop but also the new prop. Why is this change necessary? |
|
@eps1lon The current changes aren't breaking, It's meant to apply changes that should have come from the time we introduced the new preferred implementation (CSS over the previous JS measuring approach). My hope is that these changes will allow to makes the future breaking change PR more focused on removing the previous legacy implementation. |
But they do change tests which is a clear indication of a breaking change. Will revert the test changes in a follow-up since this was accidentally merged. |
The tests switch to the non legacy implementation. This implementation was untested even though we were depending on it. I believe it should have been done a long time ago. |
* next: (34 commits) [Tab] Migrate to emotion (mui#24651) [TextField] Migrate Input component to emotion (mui#24638) [ImageList] Migrate ImageListItemBar to emotion (mui#24632) [CircularProgress] Migrate to emotion (mui#24622) [DataTable] Add example in docs for data table (mui#24428) [Card] Migrate CardActionArea to emotion (mui#24636) [core] Fix `next` using stale pages (mui#24635) [List] Migrate ListItemIcon to emotion (mui#24630) [ClickAwayListener] Fix `children` and `onClickAway` types (mui#24565) [docs] Include in docs directive to silence `eslint` erroneous warning (mui#24644) [Fab] Migrate to emotion (mui#24618) [TextField] Migrate FilledInput to emotion (mui#24634) [Card] Migrate CardHeader to emotion (mui#24626) [Card] Migrate CardMedia to emotion (mui#24625) [ImageList] Migrate ImageListItem to emotion (mui#24619) [website] Add vision block (mui#24603) [docs] Add sorting section (mui#24637) [TextField] Prepare removal of labelWidth prop (mui#24595) [Dialog] Migrate DialogTitle to emotion (mui#24623) [ImageList] Migrate to emotion (mui#24615) ...
A quick follow-up after #24563, prepare the breaking change: #22799.