Skip to content

[TextField] Fix Google Translate zero-width space issue#24563

Merged
oliviertassinari merged 6 commits into
mui:nextfrom
d3mp:fix/google_zero_width_sapce_translate
Jan 24, 2021
Merged

[TextField] Fix Google Translate zero-width space issue#24563
oliviertassinari merged 6 commits into
mui:nextfrom
d3mp:fix/google_zero_width_sapce_translate

Conversation

@d3mp

@d3mp d3mp commented Jan 23, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR prevents Google Translate to translate the zero-width spaces.

Resolves: #24562

Related issues: #23236, #22719

Issue in Google Translate Help from November 2019

@mui-pr-bot

mui-pr-bot commented Jan 23, 2021 •
edited
Loading

Copy link
Copy Markdown

Details of bundle changes

Generated by 🚫 dangerJS against 01f9fe8

@d3mp d3mp changed the title [core] fix Google Translate zero width space issue [core] fix Google Translate zero-width space issue Jan 23, 2021
@d3mp
d3mp force-pushed the fix/google_zero_width_sapce_translate branch from baf6b73 to 791b86c Compare January 23, 2021 10:53
@mbrookes mbrookes added type: bug It doesn't behave as expected. external dependency Blocked by external dependency, we can’t do anything about it. labels Jan 23, 2021
@eps1lon

eps1lon commented Jan 23, 2021

Copy link
Copy Markdown
Member

Issue in Google Translate Help from November 2019

The links in that issue do no longer reproduce for me.

I can also not reproduce the problem on https://next--material-ui.netlify.app/de/components/text-fields/ with the steps described in #24562.

@d3mp

d3mp commented Jan 23, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Issue in Google Translate Help from November 2019

The links in that issue do no longer reproduce for me.

I can also not reproduce the problem on https://next--material-ui.netlify.app/de/components/text-fields/ with the steps described in #24562.

It's weird, I checked your link and I see the problem there:
image

oliviertassinari
oliviertassinari reviewed Jan 23, 2021
View reviewed changes
Comment thread packages/material-ui/src/OutlinedInput/NotchedOutline.js
Comment thread packages/material-ui/src/OutlinedInput/NotchedOutline.js
eps1lon
eps1lon approved these changes Jan 23, 2021
View reviewed changes

@eps1lon eps1lon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduces for Portugese but not Japanese for me.

@oliviertassinari oliviertassinari changed the title [core] fix Google Translate zero-width space issue [TextField] Fix Google Translate zero-width space issue Jan 23, 2021
@oliviertassinari oliviertassinari added the scope: text field Changes related to the text field. label Jan 23, 2021
@oliviertassinari

oliviertassinari commented Jan 24, 2021

Copy link
Copy Markdown
Member

@d3mp I have pushed what I meant in #24563 (comment) to its full extend with a new commit. Could you test that it's enough to fix the Google Translate issue?

@github-actions github-actions Bot mentioned this pull request Jan 24, 2021
Closed
@d3mp

d3mp commented Jan 24, 2021

Copy link
Copy Markdown
Contributor Author

@oliviertassinari I see few issues and one regression:

InputAdornment

Without translation (regression):
image
With translation:
image

HelperText

image

Select

It's completely broken in most of the places
image

ps. I still think we should prevent the translation of zero-space in any case

@oliviertassinari

oliviertassinari commented Jan 24, 2021

Copy link
Copy Markdown
Member

@d3mp Alright, let's do it in smaller steps. Thanks for the fix, I have reverted my exploration.

@oliviertassinari
oliviertassinari merged commit 5fac7d2 into mui:next Jan 24, 2021
@oliviertassinari oliviertassinari mentioned this pull request Jan 24, 2021
Merged
natac13 pushed a commit to natac13/material-ui that referenced this pull request Jan 25, 2021
@d3mp @natac13
[TextField] Fix Google Translate zero-width space issue (mui#24563)
efbebc0
eps1lon pushed a commit to eps1lon/material-ui that referenced this pull request Jan 26, 2021
@d3mp @eps1lon
[TextField] Fix Google Translate zero-width space issue (mui#24563)
a37e379
@trevoring-okta trevoring-okta mentioned this pull request Jan 31, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments
@mbrookes mbrookes mbrookes approved these changes
@eps1lon eps1lon eps1lon approved these changes

Assignees

No one assigned

Labels

external dependency Blocked by external dependency, we can’t do anything about it. scope: text field Changes related to the text field. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Google translate zero-width space problem

5 participants

@d3mp @mui-pr-bot @eps1lon @oliviertassinari @mbrookes