Skip to content

[Breadcrumbs] Migrate to emotion#24522

Merged
mnajdova merged 36 commits into
mui:nextfrom
queengooborg:migrate/Breadcrumbs
Jan 25, 2021
Merged

[Breadcrumbs] Migrate to emotion#24522
mnajdova merged 36 commits into
mui:nextfrom
queengooborg:migrate/Breadcrumbs

Conversation

@queengooborg

Copy link
Copy Markdown
Contributor

This PR migrates the Breadcrumbs component to the new emotion format as a part of #24405.

@mui-pr-bot

mui-pr-bot commented Jan 20, 2021

Copy link
Copy Markdown

@material-ui/core: parsed: +0.29% , gzip: +0.20%

Details of bundle changes

Generated by 🚫 dangerJS against 153fc5c

@queengooborg

Copy link
Copy Markdown
Contributor Author

Looks like the failing test was probably a fluke? It's only failing on a specific Edgium version for an unrelated component.

Comment thread packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Outdated
Comment thread packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Outdated
Comment thread packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Outdated
Comment thread packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Outdated
Comment thread packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Outdated
Comment thread packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Outdated
Comment thread packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Outdated
Comment thread packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Outdated
Comment thread packages/material-ui/src/Breadcrumbs/Breadcrumbs.js
Comment thread packages/material-ui/src/Breadcrumbs/Breadcrumbs.test.js Outdated
Comment thread packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Outdated
@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jan 21, 2021
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jan 21, 2021
@queengooborg

Copy link
Copy Markdown
Contributor Author

Just did a conversion of the BreadcrumbCollapsed component. Since it's a private, internal component, I noticed that the codebase was a bit different than normal -- hope I did it right!

Comment thread packages/material-ui/src/Breadcrumbs/BreadcrumbCollapsed.js Outdated
Comment thread packages/material-ui/src/Breadcrumbs/BreadcrumbCollapsed.js Outdated
Comment thread packages/material-ui/src/Breadcrumbs/BreadcrumbCollapsed.js Outdated
Comment thread packages/material-ui/src/Breadcrumbs/BreadcrumbCollapsed.js Outdated
Comment thread packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Outdated
Comment thread packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Outdated
Comment thread packages/material-ui/src/Breadcrumbs/BreadcrumbCollapsed.js Outdated
Comment thread packages/material-ui/src/Breadcrumbs/BreadcrumbCollapsed.js Outdated
Comment thread packages/material-ui/src/Breadcrumbs/breadcrumbsClasses.d.ts
Comment thread packages/material-ui/src/Breadcrumbs/breadcrumbsClasses.js
Comment thread packages/material-ui/src/Breadcrumbs/breadcrumbCollapsedClasses.js Outdated
Comment thread packages/material-ui/src/Breadcrumbs/breadcrumbCollapsedClasses.d.ts Outdated
@queengooborg

Copy link
Copy Markdown
Contributor Author

Looks like Argos is seeing the different colors for the dark theme, which is to be expected.

@mnajdova

Copy link
Copy Markdown
Member

Looks like Argos is seeing the different colors for the dark theme, which is to be expected.

@oliviertassinari are we fine with this change?

Comment thread packages/material-ui/src/Breadcrumbs/BreadcrumbCollapsed.js Outdated
Comment thread packages/material-ui/src/Breadcrumbs/Breadcrumbs.js
Comment thread packages/material-ui/src/Breadcrumbs/Breadcrumbs.js
Comment thread packages/material-ui/src/Breadcrumbs/Breadcrumbs.js
Comment thread packages/material-ui/src/Breadcrumbs/Breadcrumbs.js
@mnajdova
mnajdova merged commit 27bbb5b into mui:next Jan 25, 2021
@queengooborg
queengooborg deleted the migrate/Breadcrumbs branch January 25, 2021 07:46
natac13 pushed a commit to natac13/material-ui that referenced this pull request Jan 25, 2021
eps1lon pushed a commit to eps1lon/material-ui that referenced this pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: breadcrumbs Changes related to the breadcrumbs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants